From owner-svn-src-head@FreeBSD.ORG  Tue Aug 13 09:16:31 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 849CCBFB;
 Tue, 13 Aug 2013 09:16:31 +0000 (UTC)
 (envelope-from mavbsd@gmail.com)
Received: from mail-bk0-x233.google.com (mail-bk0-x233.google.com
 [IPv6:2a00:1450:4008:c01::233])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8A0632701;
 Tue, 13 Aug 2013 09:16:30 +0000 (UTC)
Received: by mail-bk0-f51.google.com with SMTP id mx10so2235658bkb.10
 for <multiple recipients>; Tue, 13 Aug 2013 02:16:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject
 :references:in-reply-to:content-type:content-transfer-encoding;
 bh=luKxMN3GE/mvKDnt7QNh3ofai3VPlUdcnsif9F4Rybg=;
 b=typSL1hSWbBPJ4Gx0bqnoBw0OEkiA2ZDVWE7QpgOac4gC4bltwBXIgrYpwrUVjajZT
 yIXwyzMh4WdlprOt/aUHaEy7Pmzvh+OwE55JvXVfTj7e8fSkXYlgx8pP2BL7BE2LVM8p
 l79rJvCuqWnCePIbb+FRIAnpJ9WxAhpw0ojXdFMlzfWrxYg6rtg6FDZ6Meqi1F0ynFL/
 eZ9RFf2qQI6K16lqEHA1MMvFCdjjhzW5VmwcsvTSMXL++a3Tjiq1ThtFYsjtEp2+3QYp
 kk78ESgBWrzBaw08QXcy4nt0ZoEzn2eYVTQbAh69Vz7KjAes/loZw9lCMihq+9bvab5H
 DXKg==
X-Received: by 10.204.70.141 with SMTP id d13mr1982422bkj.10.1376385387870;
 Tue, 13 Aug 2013 02:16:27 -0700 (PDT)
Received: from mavbook.mavhome.dp.ua ([37.229.21.195])
 by mx.google.com with ESMTPSA id et15sm6257332bkc.0.2013.08.13.02.16.25
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Tue, 13 Aug 2013 02:16:26 -0700 (PDT)
Sender: Alexander Motin <mavbsd@gmail.com>
Message-ID: <5209F968.4090301@FreeBSD.org>
Date: Tue, 13 Aug 2013 12:16:24 +0300
From: Alexander Motin <mav@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/20130616 Thunderbird/17.0.6
MIME-Version: 1.0
To: Andriy Gapon <avg@FreeBSD.org>
Subject: Re: svn commit: r254275 - head/sys/geom/raid
References: <201308130756.r7D7uf9o086164@svn.freebsd.org>
 <5209F2E0.9000901@FreeBSD.org>
In-Reply-To: <5209F2E0.9000901@FreeBSD.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Aug 2013 09:16:31 -0000

On 13.08.2013 11:48, Andriy Gapon wrote:
> on 13/08/2013 10:56 Alexander Motin said the following:
>> +	/* Deny write opens for read-only volumes. */
>> +	if (vol->v_read_only && acw > 0) {
>> +		error = EROFS;
>> +		goto out;
>> +	}
>
> I'd like to stir a small (hopefully) discussion (again, hopefully): is EROFS
> appropriate here or would ENODEV be better?
>
> EROFS	Read-only filesystem
> ENODEV	Operation not supported by device

I've seen both options and have no strong opinion here. Quick search via 
sources shown that some thing such as md(4) use EROFS. If that is wrong, 
lets fix it globally and forget.

-- 
Alexander Motin