From owner-freebsd-stable Wed Sep 5 15:34:36 2001 Delivered-To: freebsd-stable@freebsd.org Received: from cage.simianscience.com (cage.simianscience.com [64.7.134.1]) by hub.freebsd.org (Postfix) with ESMTP id F16FF37B405; Wed, 5 Sep 2001 15:34:24 -0700 (PDT) Received: (from root@localhost) by cage.simianscience.com (8.11.6/8.11.5) id f85MYOX21098; Wed, 5 Sep 2001 18:34:24 -0400 (EDT) (envelope-from mike@sentex.net) Received: from chimp.sentex.net (fcage [192.168.0.2]) by cage.simianscience.com (8.11.6/8.11.5av) with ESMTP id f85MY9921090; Wed, 5 Sep 2001 18:34:09 -0400 (EDT) (envelope-from mike@sentex.net) Message-Id: <5.1.0.14.0.20010905183253.039b5fa8@192.168.0.12> X-Sender: mdtancsa@192.168.0.12 X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Wed, 05 Sep 2001 18:34:08 -0400 To: "David E. Cross" From: Mike Tancsa Subject: Re: cvs commit: src/lib/libc/rpc svc_tcp.c svc_unix.c Cc: re@freebsd.org, stable@freebsd.org, freebsd-qa@freebsd.org In-Reply-To: <200109052229.f85MTNJ32998@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed X-Virus-Scanned: by AMaViS perl-10 Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi, How would it be best to test this, and is it in the RC being rolled right now? ---Mike At 03:29 PM 9/5/2001 -0700, David E. Cross wrote: >dec 2001/09/05 15:29:23 PDT > > Modified files: (Branch: RELENG_4) > lib/libc/rpc svc_tcp.c svc_unix.c > Log: > Submitted by: > Reviewed by: > Approved by: > Obtained from: > MFC after: N/A, -CURRENT no longer uses this code > The patch in 1.28.2.1 was in error. It used FD_ZERO on the fds (fdset) > structure, but this is a dunamically allocated array that is only as > big as it needs to be. The result of calling FD_ZERO on it would be that > it would either overwrite random data in the data-segment, happen to > be just the right size and work correctly, or not zero out all of the > data it was supposed to. The first case is far more likely (and damaging). > > This code has been in extensive testing here. And was approved by the > release engineers for this last minute push. > > Revision Changes Path > 1.18.2.3 +2 -2 src/lib/libc/rpc/Attic/svc_tcp.c > 1.7.2.2 +2 -2 src/lib/libc/rpc/Attic/svc_unix.c > > >To Unsubscribe: send mail to majordomo@FreeBSD.org >with "unsubscribe cvs-all" in the body of the message -------------------------------------------------------------------- Mike Tancsa, tel +1 519 651 3400 Network Administration, mike@sentex.net Sentex Communications www.sentex.net Cambridge, Ontario Canada www.sentex.net/mike To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message