From owner-svn-src-head@FreeBSD.ORG  Tue Oct 16 21:02:46 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 13708EF9;
 Tue, 16 Oct 2012 21:02:46 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
 [IPv6:2001:470:1f10:75::2])
 by mx1.freebsd.org (Postfix) with ESMTP id DA6E38FC08;
 Tue, 16 Oct 2012 21:02:45 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 48C9BB91C;
 Tue, 16 Oct 2012 17:02:45 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Maksim Yevmenkin <emax@freebsd.org>
Subject: Re: svn commit: r241616 - in head/sys: dev/ixgbe net
Date: Tue, 16 Oct 2012 17:02:06 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p20; KDE/4.5.5; amd64; ; )
References: <201210162018.q9GKIG9q013028@svn.freebsd.org>
In-Reply-To: <201210162018.q9GKIG9q013028@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201210161702.06330.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Tue, 16 Oct 2012 17:02:45 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Oct 2012 21:02:46 -0000

On Tuesday, October 16, 2012 4:18:16 pm Maksim Yevmenkin wrote:
> Author: emax
> Date: Tue Oct 16 20:18:15 2012
> New Revision: 241616
> URL: http://svn.freebsd.org/changeset/base/241616
> 
> Log:
>   introduce concept of ifi_baudrate power factor. the idea is to work
>   around the problem where high speed interfaces (such as ixgbe(4))
>   are not able to report real ifi_baudrate. bascially, take a spare
>   byte from struct if_data and use it to store ifi_baudrate power
>   factor. in other words,
>   
>   real ifi_baudrate = ifi_baudrate * 10 ^ ifi_baudrate power factor
>   
>   this should be backwards compatible with old binaries. use ixgbe(4)
>   as an example on how drivers would set ifi_baudrate power factor
>   
>   Discussed with:	kib, scottl, glebius
>   MFC after:	1 week

It would be a lot nicer if you could still allow one to use more
readable things like IF_Gbps(10).  Note that we do have a 40G driver
(mlxen) as well.

Maybe a helper 'if_set_baudrate(ifp, IF_Gbps(10))' that would DTRT.
(It could be a static inline or some such).  I would just like to
keep the readability.

-- 
John Baldwin