Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 18 Apr 2023 17:43:01 +0100
From:      Norman Gray <gray@nxg.name>
To:        Michael Grimm <trashcan@ellael.org>
Cc:        questions@freebsd.org, Doug Hardie <bc979@lafn.org>
Subject:   Re: Blacklistd Issues - Problem Identified
Message-ID:  <AB045FC9-5EC4-426F-B6C2-CB61008A3356@nxg.name>
In-Reply-To: <F025AE6A-A820-412E-A0F1-F551D719E319@ellael.org>
References:  <C632EC86-6745-42F9-A5EE-FE604C7A8599@sermon-archive.info> <8B1C1DCE-75CA-4CE9-A589-329519FB792E@sermon-archive.info> <4E4A4B99-D8DF-4C5C-9700-C56F354A9991@sermon-archive.info> <24171551-4181-49C8-B1DE-2C3D9A00DC4C@sermon-archive.info> <6BD45EAE-D626-4B16-8C24-197FFE34E601@ellael.org> <8FEE687C-E342-49CF-B3D9-118D7ADB84AA@nxg.name> <F025AE6A-A820-412E-A0F1-F551D719E319@ellael.org>

next in thread | previous in thread | raw e-mail | index | archive | help

Michael, hello.

On 18 Apr 2023, at 12:21, Michael Grimm wrote:

>> However, that would be my first time with the FreeBSD sources.  Is the=
re a standard process for this?
>
>  I am not an expert either, but I would first of all open a PR. Their y=
ou can publish your patches against sources. Someone else will later comm=
it your patch if accepted.

Sounds good....

>> I notice that the blacklistd sources aren't in <https://github.com/fre=
ebsd/freebsd-src/tree/main/usr.sbin/blacklistd> , so I'm stuck at step 1.=

>
>  The sources are at:
>
>  /usr/src/contrib/blacklist
>
>  In /usr/src/contrib/blacklist/bin you'll find blacklistd.conf and the =
config files in /usr/src/contrib/blacklist/etc

I can see the sources if I include src when installing from dvd1.  So far=
 so good...

I think I may need to be pointed towards some further reading, though.  I=
n (a copy of) /usr/src/contrib/blacklist I try 'make', and that doesn't w=
ork (illustrated below) because there's clearly a -I missing (ie, I'm dou=
btless doing this in the wrong place).

Looking at [1], /usr/src/Makefile, and /usr/src/UPDATING, I'm getting the=
 impression that the only documented process is 'make world' or 'make bui=
ldworld'.  Would that be right?  Even in this simple case where the sourc=
es are associated with the userland on the same install image?

Thanks for any pointers,

Norman


[1] https://docs.freebsd.org/en/books/handbook/cutting-edge/#makeworld


%  make
=3D=3D=3D> lib (all)
cc  -O2 -pipe -fno-common   -g -MD  -MF.depend.bl.o -MTbl.o -std=3Dgnu99 =
-Wno-format-zero-length -fstack-protector-strong -Wsystem-headers -Werror=
 -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmis=
sing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings=
 -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Wne=
sted-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -=
Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-strin=
g-plus-int -Wno-unused-const-variable -Wno-error=3Dunused-but-set-variabl=
e  -Qunused-arguments    -c bl.c -o bl.o
bl.c:60:10: fatal error: 'bl.h' file not found
#include "bl.h"
         ^~~~~~
1 error generated.
*** Error code 1

Stop.
make[1]: stopped in /usr/src/contrib/blacklist-mod/lib
*** Error code 1

Stop.
make: stopped in /usr/src/contrib/blacklist-mod


-- =

Norman Gray  :  https://nxg.me.uk



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AB045FC9-5EC4-426F-B6C2-CB61008A3356>