From owner-cvs-all Wed Jan 24 0: 7:10 2001 Delivered-To: cvs-all@freebsd.org Received: from shale.csir.co.za (shale.csir.co.za [146.64.46.5]) by hub.freebsd.org (Postfix) with ESMTP id AFB6E37B401; Wed, 24 Jan 2001 00:06:45 -0800 (PST) Received: from C992631-A.pinol1.sfba.home.com (C992631-A.pinol1.sfba.home.com [24.12.58.155]) by shale.csir.co.za (8.9.3/8.9.3) with ESMTP id KAA29605; Wed, 24 Jan 2001 10:06:33 +0200 (SAT) (envelope-from reg@shale.csir.co.za) Received: (from reg@localhost) by C992631-A.pinol1.sfba.home.com (8.11.1/8.11.1) id f0O86I722789; Wed, 24 Jan 2001 00:06:18 -0800 (PST) (envelope-from reg) Date: Wed, 24 Jan 2001 00:06:17 -0800 From: Jeremy Lea To: Maxim Sobolev Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/add extract.c main.c src/usr.sbin/pkg_install/create create.h main.c perform.c pkg_create.1 src/usr.sbin/pkg_install/lib file.c plist.c Message-ID: <20010124000617.C63549@shale.csir.co.za> Mail-Followup-To: Jeremy Lea , Maxim Sobolev , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200101221201.f0MC1tV27540@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200101221201.f0MC1tV27540@freefall.freebsd.org>; from sobomax@FreeBSD.org on Mon, Jan 22, 2001 at 04:01:55AM -0800 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Hi, On Mon, Jan 22, 2001 at 04:01:55AM -0800, Maxim Sobolev wrote: > Modified files: > usr.sbin/pkg_install/add extract.c main.c > usr.sbin/pkg_install/create create.h main.c perform.c > pkg_create.1 > usr.sbin/pkg_install/lib file.c plist.c > Log: > - Add ability to handle bzip2-compressed packages; The code in create/main.c never turns UseBzip2 = TRUE. Which implies it was never tested, which also implies that the command line switch is redundant. We can guess bzip2 compression from the suffix. In fact we have to have a bzip2 suffix, else we can't guess how to extract it, so having a command line switch can only cause bad things to happen. > No response from: -ports This should have read Approved by: jkh He is the maintainer of this code, not -ports. (Even if he never changes it or reviews patches :-( ) Regards, -Jeremy -- FreeBSD - Because the best things in life are free... http://www.freebsd.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message