Date: Sun, 10 Jun 2001 10:18:27 -0700 (PDT) From: Matthew Jacob <mjacob@feral.com> To: Doug Barton <DougB@DougBarton.net> Cc: John Polstra <jdp@polstra.com>, <ports@FreeBSD.ORG> Subject: Re: not sure if this is a good patch or not... (fwd) Message-ID: <20010610101802.L7065-100000@wonky.feral.com> In-Reply-To: <3B22B05F.16227A31@DougBarton.net>
next in thread | previous in thread | raw e-mail | index | archive | help
I didn't quite follow how this is supposed to be used. I made a half-hearte=
d
attempt to figure it out, but couldn't follow it.
On Sat, 9 Jun 2001, Doug Barton wrote:
> =09It's much better to use the value of ${PTHREAD_LIBS} somehow, possibly=
in
> CONFIGURE_ENV if the port will support it. PTHREAD_LIBS does the right
> thing on both -current and RELENG_4.
>
> Doug
>
> John Polstra wrote:
> >
> > In article <20010609132536.R4572-100000@wonky.feral.com>,
> > Matthew Jacob <mjacob@feral.com> wrote:
> >
> > > Needed to compile under 4.3:
> > >
> > > Index: files/patch-Makefile.Linux.Mesa
> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > > RCS file: /home/ncvs/ports/games/tank/files/patch-Makefile.Linux.Mesa=
,v
> > > retrieving revision 1.1
> > > diff -u -r1.1 patch-Makefile.Linux.Mesa
> > > --- files/patch-Makefile.Linux.Mesa 2001/03/14 12:20:49 1.1
> > > +++ files/patch-Makefile.Linux.Mesa 2001/06/09 20:16:59
> > > @@ -38,7 +38,7 @@
> > > $(CC) -o $(EXECNAME) $(Obj) $(LDFLAGS) \
> > > - -lMesaaux -lMesatk -lMesaGLU -lMesaGL \
> > > - -lXext -lX11 -lm
> > > -+ -laux -lGLU -lGL -lXext -lX11 -lm
> > > ++ -laux -lGLU -lGL -lXext -lX11 -lm -lc_r
> > > @echo "****** Done ******"
> > >
> > > linux: $(Obj)
> > >
> >
> > Not a good patch. Add "-pthread" to LDFLAGS instead. The patch as
> > it stands will link in both -lc_r and -lc, but the two cannot coexist
> > safely.
> >
> > John
> > --
> > John Polstra jdp@polstr=
a.com
> > John D. Polstra & Co., Inc. Seattle, Washingto=
n USA
> > "Disappointment is a good sign of basic intelligence." -- Ch=F6gyam =
Trungpa
> >
> > To Unsubscribe: send mail to majordomo@FreeBSD.org
> > with "unsubscribe freebsd-ports" in the body of the message
>
> --
> If you're never wrong, you're not trying hard enough.
>
> Do YOU Yahoo!?
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010610101802.L7065-100000>