From owner-freebsd-hackers Wed Jul 28 17:56:51 1999 Delivered-To: freebsd-hackers@freebsd.org Received: from apollo.backplane.com (apollo.backplane.com [209.157.86.2]) by hub.freebsd.org (Postfix) with ESMTP id 2EABA1529E; Wed, 28 Jul 1999 17:56:37 -0700 (PDT) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.9.3/8.9.1) id RAA65104; Wed, 28 Jul 1999 17:55:58 -0700 (PDT) (envelope-from dillon) Date: Wed, 28 Jul 1999 17:55:58 -0700 (PDT) From: Matthew Dillon Message-Id: <199907290055.RAA65104@apollo.backplane.com> To: "Brian F. Feldman" Cc: Nate Williams , hackers@FreeBSD.ORG, freebsd-ipfw@FreeBSD.ORG Subject: Re: securelevel and ipfw zero References: Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG :On Wed, 28 Jul 1999, Nate Williams wrote: :> > :> > These were changes that were necessary to make ipfw readable enough that :> > I could work with it in this area. They aren't just to clean it up, or :> > just for change's sake. They need to stay in. :> :> C'mon now, re-ording the lines is *certainly* not necessary to work. : :That's true. I sure didn't do that. : :> :> *rant on* :> Brian, FreeBSD isn't your private playground for playing around, this is :> a group project, and you gotta follow the rules, or you don't get to :> play with the rest of the folks.... : :The rules don't say "leave the code that you work with in a bigger mess than :when you started." Cleaning up code is a fact of life, and it _NEEDS_ to be :done to get work done, very often. You have to learn to deal with that. : :> *rant off* :> :> Nate :> : Brian Fundakowski Feldman _ __ ___ ____ ___ ___ ___ : green@FreeBSD.org _ __ ___ | _ ) __| \ Side note: I do the same thing: clean up certain portions of the code in order to make them more readable while I'm working on the module. And while I tend to agree that it would be nice to commit the bug fixes separately, it just isn't practical most of the time because one might have already spent too big a chunk of one's own time to do the work in the first place. And I get the same sort of crap from certain core members, too. It's truely annoying when you've spent the time ( sometimes a whole LOT of time ) and trouble to fix something and all some people can do is complain about extremely trivial elements of the work. -Matt Matthew Dillon To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message