From owner-svn-src-head@FreeBSD.ORG Tue Aug 5 14:30:07 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CB75095A for ; Tue, 5 Aug 2014 14:30:07 +0000 (UTC) Received: from mail-pd0-f172.google.com (mail-pd0-f172.google.com [209.85.192.172]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 968262508 for ; Tue, 5 Aug 2014 14:30:07 +0000 (UTC) Received: by mail-pd0-f172.google.com with SMTP id ft15so1451678pdb.31 for ; Tue, 05 Aug 2014 07:30:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=78JprRbcANJLLsbw2m93p9TFSS6B9bH31oilMY5mD9Y=; b=U1wCv8rijrOrtwnpB6/gIZQI8MtTqf4mmwDj4MvyUUxoMEDeOEqaDidNiol1WBJ3R6 KpDGfPrWOkSZ8APgZzxNVwe1QqoyRGps8z4t5W8o6ItI69oLmV2AicRQZFncikCmo9M8 2PejApye2NA5cIiOESPhMr316gTgtmc/0Q8KPg0flzQP3UZ4vGUi/CoHHfUZyWVF9EJv KHdNiXX2wD1UGwvMZ3IoOLwbJF7yV+4QRD+am67E0GCGFm02gtjeW1ap/drP4JOhHQ0m Up63m5okWfFWsStjkSWpb/DzG1lyCq2FtfAmEbTEgaC90QYcH7CrMLo6Z6TndYK8ys1X LO/w== X-Gm-Message-State: ALoCoQmcS/nLuwFA9jvtWhFLM315R8ca/HfJupKGV4n9eNIPqJgbafqi/tqfQdeCT/ZM0sWcPUaD X-Received: by 10.70.35.15 with SMTP id d15mr4789353pdj.48.1407249000944; Tue, 05 Aug 2014 07:30:00 -0700 (PDT) Received: from [10.64.25.9] (dc1-prod.netflix.com. [69.53.236.251]) by mx.google.com with ESMTPSA id mn2sm2239582pbc.64.2014.08.05.07.29.59 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 05 Aug 2014 07:30:00 -0700 (PDT) Sender: Warner Losh Content-Type: multipart/signed; boundary="Apple-Mail=_1246B2AD-3F1F-4E76-9180-F33B3A4FEF27"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r269540 - in head/sys: conf modules/an modules/arcnet modules/cam modules/carp modules/cxgb/cxgb modules/cxgb/iw_cxgb modules/cxgb/tom modules/cxgbe/if_cxgbe modules/cxgbe/iw_cxgbe modu... From: Warner Losh In-Reply-To: <998B3BD1-A9BD-40DA-B13A-15636D3DCFF0@FreeBSD.org> Date: Tue, 5 Aug 2014 08:29:57 -0600 Message-Id: <608EE963-4680-47AC-932E-D3ABD5BC5BCD@bsdimp.com> References: <53e00b0f.529c.265fe830@svn.freebsd.org> <998B3BD1-A9BD-40DA-B13A-15636D3DCFF0@FreeBSD.org> To: "Bjoern A. Zeeb" X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Warner Losh X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Aug 2014 14:30:07 -0000 --Apple-Mail=_1246B2AD-3F1F-4E76-9180-F33B3A4FEF27 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Aug 5, 2014, at 4:52 AM, Bjoern A. Zeeb wrote: >=20 > On 05 Aug 2014, at 10:31 , Bjoern A. Zeeb wrote: >=20 >>=20 >> On 04 Aug 2014, at 22:37 , Warner Losh wrote: >>=20 >>> Author: imp >>> Date: Mon Aug 4 22:37:02 2014 >>> New Revision: 269540 >>> URL: http://svnweb.freebsd.org/changeset/base/269540 >>>=20 >>> Log: >>> Move most of the 15 variations on generating opt_inet.h and >>> opt_inet6.h into kmod.mk by forcing almost everybody to eat the same >>> dogfood. While at it, consolidate the opt_bpf.h and opt_mroute.h >>> targets here too. >>>=20 >>> Modified: >>> head/sys/conf/kern.opts.mk >>> head/sys/conf/kmod.mk >>> head/sys/modules/an/Makefile >>> head/sys/modules/arcnet/Makefile >>> head/sys/modules/cam/Makefile >>> head/sys/modules/carp/Makefile >>> head/sys/modules/cxgb/cxgb/Makefile >>> head/sys/modules/cxgb/iw_cxgb/Makefile >>> head/sys/modules/cxgb/tom/Makefile >>> head/sys/modules/cxgbe/if_cxgbe/Makefile >>> head/sys/modules/cxgbe/iw_cxgbe/Makefile >>> head/sys/modules/cxgbe/tom/Makefile >>> head/sys/modules/dummynet/Makefile >>> head/sys/modules/em/Makefile >>> head/sys/modules/en/Makefile >>> head/sys/modules/fatm/Makefile >>> head/sys/modules/firewire/fwip/Makefile >>> head/sys/modules/hatm/Makefile >>> head/sys/modules/i40e/Makefile (contents, props changed) >>> head/sys/modules/if_bridge/Makefile >>> head/sys/modules/if_disc/Makefile >>> head/sys/modules/if_faith/Makefile >>> head/sys/modules/if_gif/Makefile >>> head/sys/modules/if_gre/Makefile >>> head/sys/modules/if_lagg/Makefile >>> head/sys/modules/if_stf/Makefile >>> head/sys/modules/if_tap/Makefile >>> head/sys/modules/if_tun/Makefile >>> head/sys/modules/igb/Makefile >>> head/sys/modules/ip6_mroute_mod/Makefile >>> head/sys/modules/ip_mroute_mod/Makefile >>> head/sys/modules/ipdivert/Makefile >>> head/sys/modules/ipfilter/Makefile >>> head/sys/modules/ipfw/Makefile >>> head/sys/modules/ipoib/Makefile >>> head/sys/modules/ixgbe/Makefile >>> head/sys/modules/krpc/Makefile >>> head/sys/modules/linux/Makefile >>> head/sys/modules/lmc/Makefile >>> head/sys/modules/mlx4/Makefile >>> head/sys/modules/mlx4ib/Makefile >>> head/sys/modules/mlxen/Makefile >>> head/sys/modules/mthca/Makefile >>> head/sys/modules/netgraph/gif/Makefile >>> head/sys/modules/netgraph/iface/Makefile >>> head/sys/modules/netgraph/ipfw/Makefile >>> head/sys/modules/netgraph/netflow/Makefile >>> head/sys/modules/nfscl/Makefile >>> head/sys/modules/nfsclient/Makefile >>> head/sys/modules/nfslockd/Makefile >>> head/sys/modules/nfsserver/Makefile >>> head/sys/modules/patm/Makefile >>> head/sys/modules/pf/Makefile >>> head/sys/modules/pflog/Makefile >>> head/sys/modules/pfsync/Makefile >>> head/sys/modules/smbfs/Makefile >>> head/sys/modules/snc/Makefile >>> head/sys/modules/sppp/Makefile >>> head/sys/modules/trm/Makefile >>> head/sys/modules/virtio/network/Makefile >>> head/sys/modules/vmware/vmxnet3/Makefile >>> head/sys/modules/wlan/Makefile >>> head/sys/modules/wlan_acl/Makefile >>> head/sys/modules/wlan_amrr/Makefile >>> head/sys/modules/wlan_ccmp/Makefile >>> head/sys/modules/wlan_rssadapt/Makefile >>> head/sys/modules/wlan_tkip/Makefile >>> head/sys/modules/wlan_wep/Makefile >>> head/sys/modules/wlan_xauth/Makefile >>=20 >> This broke a couple of kernel builds during universe: >>=20 >> mips AP91 kernel failed, check _.mips.AP91 for details >> mips AP93 kernel failed, check _.mips.AP93 for details >> mips AR724X_BASE kernel failed, check _.mips.AR724X_BASE for details >> mips ENH200 kernel failed, check _.mips.ENH200 for details >> mips DIR-825B1 kernel failed, check _.mips.DIR-825B1 for details >> mips PB92 kernel failed, check _.mips.PB92 for details >> mips PICOSTATION_M2HP kernel failed, check _.mips.PICOSTATION_M2HP = for details >> mips WZR-300HP kernel failed, check _.mips.WZR-300HP for details >> arm EFIKA_MX kernel failed, check _.arm.EFIKA_MX for details >>=20 >>=20 >> They all seem to not define INET6 and AP91 errors look like this; = all seem to barf in the if_gif module built. Please investigate and = unbreak. Would be really nice if these commits were tested to build = and still give the same results upfront. I am mostly worried about the = latter actually. >=20 > I should have fixed the build in r269581. The other concern remains. Thanks Bjoern=85 I had a different, working change that I ran through Universe earlier in = my development process. I reworked it though as part of teasing = different changes apart of a larger change set, though, and the error = crept in there. That=92s my bad. Thanks for fixing it. Warner --Apple-Mail=_1246B2AD-3F1F-4E76-9180-F33B3A4FEF27 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJT4OplAAoJEGwc0Sh9sBEA4xoQAKGd4mD4vQBIDAj63UovgA2j nGUSNkJs/8D0y1UA9W2u6B6fkyJdUXqks+a188s3Vy6LLfS5U99LAnSAoR7hrOQS dRWyyWgARKpW5KEgr7w+AH1RJqqeR50ig3NT8m9GnE97benrGBa/9AEfDawMVMot kpgRgcY7OkDDMGiNeqBrZsU0Jrq3uR46sFfq6SmzTCrucRp+rWrykyCMxFsL5jAZ 00VuAQoVQk/S4fTeu56RCQ0+OyyKOomCI3midcpzJ4WsKDk/Fle3WOpao2azNwrn mhh2XxmkO4wJ9D7CvrPyoIbuSA1oxuwKU0MFQxL3zXGxtXDKmcsQBPMiT8aHxguR HItID6KyLUA55sqx1EhAdniPDE6pALhwj8YRzsPE/hBP/LaZ4Xcjt4HBOkBEY9gO IoyB3Pk5Zj28PEa5rSFXXiM8sv2bQIoJh8KhSyiFEBjAn6+uiJ5sV17xUdz1TRfv 324WR8sxwRYzXQVjomxfRUvaaFJvf82SAmImbuxIaKT02COxw+yl+hQIEwnhB/x7 TGwa4V2M9+tG9aa2AquUYZ2NdNQB9BRBxdOb5yL4q5+zCbyqSH5PcaMWk+zECXBP o0xJINnukCjP4TbqkideimWHcYnPP3WP9qcx9xAarFQGNKCREhxbpGCcxEl3WHhx 9mRb9tsFof7TVoHcl//y =E+op -----END PGP SIGNATURE----- --Apple-Mail=_1246B2AD-3F1F-4E76-9180-F33B3A4FEF27--