From owner-cvs-all@FreeBSD.ORG Mon Apr 30 22:35:35 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1830C16A401; Mon, 30 Apr 2007 22:35:35 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 0A58D13C459; Mon, 30 Apr 2007 22:35:35 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3UMZYsO028387; Mon, 30 Apr 2007 22:35:34 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3UMZYUD028386; Mon, 30 Apr 2007 22:35:34 GMT (envelope-from marius) Message-Id: <200704302235.l3UMZYUD028386@repoman.freebsd.org> From: Marius Strobl Date: Mon, 30 Apr 2007 22:35:33 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/mii brgphy.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2007 22:35:35 -0000 marius 2007-04-30 22:35:33 UTC FreeBSD src repository Modified files: sys/dev/mii brgphy.c Log: - Take advantage of mii_phy_add_media() for adding media and setting sc->mii_anegticks according to whether the respective BGE chip supports Fast Ethernet only or also Gigabit Ethernet. - At least the BGE chips I've tested with wedge when isolating them so document this as the reason for setting MIIF_NOISOLATE and remove the unused (and partially even #ifdef'ed out) isolation related code. Add code that panics if we encounter a non-zero MII instance as generally there's no way a PHY requiring MIIF_NOISOLATE can be handled gracefully in a multi-PHY configuration (it's ok for the internal PHY of single-PHY-only-NIC to not support isolation though). - Additionally set MIIF_NOLOOP as loopback doesn't seem to work either and remove the #ifdef'ed out code for adding respective media. The MIIF_NOLOOP flag currently triggers nothing but hopefully will be respected by mii_phy_setmedia() later on. Reviewed by: jkim, yongari MFC after: 1 month Revision Changes Path 1.68 +13 -65 src/sys/dev/mii/brgphy.c