Date: Mon, 21 May 2012 22:46:50 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: Kevin Lo <kevlo@FreeBSD.org>, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Baptiste Daroussin <baptiste.daroussin@gmail.com> Subject: Re: svn commit: r235771 - head/bin/expr Message-ID: <D4174415-5DCB-45E3-81BD-5F3B82E82DF3@gmail.com> In-Reply-To: <20120522054113.GL63744@ithaqua.etoilebsd.net> References: <201205220301.q4M31tJn084097@svn.freebsd.org> <CAGH67wR9OCq93bWCfJPn6WXNFfVUthBrUhtxpHDRVQXWavx9yg@mail.gmail.com> <20120522054113.GL63744@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On May 21, 2012, at 10:41 PM, Baptiste Daroussin wrote: > On Mon, May 21, 2012 at 09:20:59PM -0700, Garrett Cooper wrote: >> On Mon, May 21, 2012 at 8:01 PM, Kevin Lo <kevlo@freebsd.org> wrote: >>> Author: kevlo >>> Date: Tue May 22 03:01:54 2012 >>> New Revision: 235771 >>> URL: http://svn.freebsd.org/changeset/base/235771 >>>=20 >>> Log: >>> Remove redundant declaration of yyparse >>>=20 >>> Reported by: tinderbox >>>=20 >>> Modified: >>> head/bin/expr/expr.y >>>=20 >>> Modified: head/bin/expr/expr.y >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- head/bin/expr/expr.y Tue May 22 02:37:04 2012 = (r235770) >>> +++ head/bin/expr/expr.y Tue May 22 03:01:54 2012 = (r235771) >>> @@ -74,7 +74,6 @@ int to_integer(struct val *); >>> void to_string(struct val *); >>> int yyerror(const char *); >>> int yylex(void); >>> -int yyparse(void); >>>=20 >>> %} >>=20 >> There are a lot more than just this unfortunately (I'm working on >> a complete patchset). >> This breakage really makes me think that yacc isn't being built at >> the right time or pathed properly in the build system. >=20 > The complete patch set is there: > http://people.freebsd.org/~bapt/fix-after-yacc.diff > (clang seems to not detect those redudant warning, while gcc = complains) >=20 > I'm waiting for review before committing) >=20 > Thanks for this fix I'll remove it from my patchset Yeah, that looks about right (I was about 4/5 of the way there, = but you beat me to the punch :)..). Cheers! -Garrett=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D4174415-5DCB-45E3-81BD-5F3B82E82DF3>