From owner-cvs-all Mon Oct 7 15:45:21 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 618DC37B505 for ; Mon, 7 Oct 2002 15:44:58 -0700 (PDT) Received: from mail.speakeasy.net (mail15.speakeasy.net [216.254.0.215]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7741143E97 for ; Mon, 7 Oct 2002 15:44:56 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 24404 invoked from network); 7 Oct 2002 22:44:55 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail15.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 7 Oct 2002 22:44:55 -0000 Received: from laptop.baldwin.cx (laptop.baldwin.cx [192.168.0.4]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id g97Misn5003714; Mon, 7 Oct 2002 18:44:54 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200210072235.g97MZEZv006342@green.bikeshed.org> Date: Mon, 07 Oct 2002 18:44:58 -0400 (EDT) From: John Baldwin To: "Brian F. Feldman" Subject: Re: cvs commit: src/sys/boot/i386/boot2 Makefile Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 07-Oct-2002 Brian F. Feldman wrote: > Poul-Henning Kamp wrote: >> In message <200210072221.g97MLGNL093580@freefall.freebsd.org>, Brian Feldman wr >> ites: >> >green 2002/10/07 15:21:16 PDT >> > >> > Modified files: >> > sys/boot/i386/boot2 Makefile >> > Log: >> > Correct a bug in adding 0x700 to a number. >> >> It's bedtime here, way past in fact, and I'm not going into the lab >> again to find out what this does/is intended to do. >> >> I succesfully booted on UFS1 and UFS2 without this change, but that >> doesn't necessarily mean that you broke it. >> >> I just hope you know what you're doing... > > At some point someone decided bogusly that the way to add a number to 0x700 > was to concatenate it. I corrected that, so if xread is at an offset of > > 0xff it won't completely fsck itself. Since boot1 is only 512 bytes long and xread is always at the front, I don't see how this is really a problem actually. Sheesh, it used to be a hardcoded constant into boot2 before the script was added! -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message