From owner-cvs-all Thu Dec 3 20:14:16 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id UAA16116 for cvs-all-outgoing; Thu, 3 Dec 1998 20:14:16 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from nagual.pp.ru (lsd.relcom.eu.net [193.125.27.73]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id UAA16103; Thu, 3 Dec 1998 20:14:13 -0800 (PST) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.9.1/8.9.1) id HAA42809; Fri, 4 Dec 1998 07:13:58 +0300 (MSK) (envelope-from ache) Message-ID: <19981204071357.A41880@nagual.pp.ru> Date: Fri, 4 Dec 1998 07:13:57 +0300 From: "Andrey A. Chernov" To: Matt Dillon , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet icmp_var.h Mail-Followup-To: Matt Dillon , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <199812040349.TAA22636@freefall.freebsd.org> <19981204070811.A40154@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.93.2i In-Reply-To: <19981204070811.A40154@nagual.pp.ru>; from ache@nagual.pp.ru on Fri, Dec 04, 1998 at 07:08:11AM +0300 Organization: Biomechanoid Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Fri, Dec 04, 1998 at 07:08:11AM +0300, Andrey A. Chernov wrote: > On Thu, Dec 03, 1998 at 07:49:19PM -0800, Matt Dillon wrote: > > dillon 1998/12/03 19:49:18 PST > > Quick add #ifdef KERNEL for ICMP_BANDLIM option so userland program > > can #include icmp_var.h > > badport_badlim should be #ifdef'ed KERNEL too to prevent name pollution. > No user-visible stuff should depend on ICMP_BANDLIM option, it is legal > name and can be used by user freely. No optional compilation of this user > header file allowed, it means you need to make BANDLIM sysctl always > visible and get rid of ICMP_BANDLIM option from sysctl definition too. See > my previous message on this subject. Just to add: if you get rid of ICMP_BANDLIM option from this header file, you can remove opt_icmp_bandlim.h from it too! I assume you later include opt_icmp_bandlim.h in kernel *.c files which really need it, it is better variant because now too many files will be recompiled if BANDLIM option changed. -- Andrey A. Chernov http://www.nagual.pp.ru/~ache/ MTH/SH/HE S-- W-- N+ PEC>+ D A a++ C G>+ QH+(++) 666+>++ Y To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message