From owner-svn-src-all@freebsd.org Tue Feb 26 06:15:01 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 02FE9150CC5E; Tue, 26 Feb 2019 06:15:01 +0000 (UTC) (envelope-from jason.harmening@gmail.com) Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 67D8B6D66E; Tue, 26 Feb 2019 06:15:00 +0000 (UTC) (envelope-from jason.harmening@gmail.com) Received: by mail-pf1-x429.google.com with SMTP id n74so5697525pfi.9; Mon, 25 Feb 2019 22:15:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=M9piqBWP4w50ijgNzPS2a5dISVdQ9cj+slvwHV3YANk=; b=IRDTn4X41Mgg2QsSIdTPxomNM/KIc4FW4hsx3mZuMC015VPi1AxUsF6oRUmIqAvs3v XrBtvksmsyaQkQOQq2T/igK9kaUKtIYkzWGZnt6OmGTdr1XTP8jLNEzpjCAEEcVDz/W4 zl71NSr9VPjfBPhRNKwO1+FL6iTGo+k9bcu/PxPQfB/USG34coO2OHne9m/TXaMxB4nx OmrbHHhvQ1f1ohvrdx+ktgoLFwjTQwM+BOwbijwQkqlmMjjGRIF0Uc80jbdRwvnvoKHR +SryzkvmVteNbm9fY8SbDs81j4c1jXejYulSyyzLDKmWHcDB6kZABSXvT0urjoO/KEuJ M+vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=M9piqBWP4w50ijgNzPS2a5dISVdQ9cj+slvwHV3YANk=; b=Y6S4Uruos5HVz2GMqeMcMK8ui9hK/zXh46kICtd62ZX30SQdzfYmAnceZ1OtSPCbQX 8QoXOSXC3QgTRKFAhcACYjC2eH8Jm339ktM3EEX/UlBahx9hfK/k4hSgyaS64d9UIDlL 5+70sjFJNcKTvlHhV/ov7bC1QmVeZCVmYaWGGXIpbBuH7Q+8J1+OzMjnMHv5cABPpbzX D/IbCh67aS62+oif4nJCL7Bt3Ab6O6Tre78zDqjSuGHvwLtiSQeso/Yc0PXl68QsD6qf te5zxEhW4hPCpv1Ndjrmjz3JukXOoNk91i0z+hr1qg11OyMqZM24jeulAzxqyfvq4s6C X0Qw== X-Gm-Message-State: AHQUAuZjtNMqq/DUp9L6HRTQ0BYRSqn3qe8QeshDBibQUfWKRk5hLsXT sfrn8p24C+xGIhQbM+rZzQusDMk= X-Google-Smtp-Source: AHgI3IasmUIuqZu0oAhKz37/IaSiFypNQaqc19x23rIa5m+bULUa0WARpsHqdpMggZOHvsFLLR3o8Q== X-Received: by 2002:a63:29c3:: with SMTP id p186mr23013602pgp.24.1551161698675; Mon, 25 Feb 2019 22:14:58 -0800 (PST) Received: from [192.168.1.2] (c-67-188-30-11.hsd1.ca.comcast.net. [67.188.30.11]) by smtp.googlemail.com with ESMTPSA id p86sm24026212pfa.104.2019.02.25.22.14.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 22:14:57 -0800 (PST) Subject: Re: svn commit: r344562 - head/sys/ufs/ffs To: Bruce Evans , "Jason A. Harmening" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201902260456.x1Q4uAIu056382@repo.freebsd.org> <20190226162300.M1437@besplex.bde.org> From: Jason Harmening Message-ID: <414d1964-f822-33f2-8177-872a4cbedd13@gmail.com> Date: Mon, 25 Feb 2019 22:12:52 -0800 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.3.2 MIME-Version: 1.0 In-Reply-To: <20190226162300.M1437@besplex.bde.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 67D8B6D66E X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.96)[-0.964,0]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 06:15:01 -0000 On 2/25/19 9:46 PM, Bruce Evans wrote: > > block_size <= PAGE_SIZE is very uncommon for ffs, even on systems with > large > pages.  MINBSIZE is 4096 in ffs (except in my version, it is 512).  The > default is 32768 in newfs.  I consider this excessive and only use it for > file systems with many files larger than 1GB, but it is the most common > size. > It is larger than the large page size of 8192. I think this is a case of filesystem logical block size vs. media sector size, right? Here we're checking the devvp's block size, which I think should correspond to the sector size. I'd expect cases of that being greater than PAGE_SIZE to be uncommon, in fact geli warns when that is the case. I probably should've made that clearer in the commit message. > > ffs_getpages() already has an almost-never-used special case for small > block sizes.  It uses vnode_pager_generic_getpages() when !use_buf_pager > and the block_size <= PAGE_SIZE, else vfs_bio_getpages().  But > block_size <= PAGE_SIZE is unusual, and !use_buf_pager is also unusual, > and use_buf_pager is mostly a debugging sysctl, so little would be > lost but using vfs_bio_getpages() unconditionally. > > Bruce