From owner-svn-src-head@FreeBSD.ORG  Wed Dec  4 14:46:56 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 9BA77387;
 Wed,  4 Dec 2013 14:46:56 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 6EA6415EF;
 Wed,  4 Dec 2013 14:46:56 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 63422B98E;
 Wed,  4 Dec 2013 09:46:55 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Eitan Adler <eadler@freebsd.org>
Subject: Re: svn commit: r258901 - head/usr.sbin/mfiutil
Date: Wed, 4 Dec 2013 08:56:14 -0500
User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20130906; KDE/4.5.5; amd64; ; )
References: <201312040028.rB40Sj9l061474@svn.freebsd.org>
 <CAF6rxg=ZdkSwq26vAE8OMgVUGhWoUCcjxyJ2CO+ymmTO3xYudA@mail.gmail.com>
In-Reply-To: <CAF6rxg=ZdkSwq26vAE8OMgVUGhWoUCcjxyJ2CO+ymmTO3xYudA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201312040856.14579.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Wed, 04 Dec 2013 09:46:55 -0500 (EST)
Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 Sean Bruno <sbruno@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Dec 2013 14:46:56 -0000

On Wednesday, December 04, 2013 12:00:16 am Eitan Adler wrote:
> On Tue, Dec 3, 2013 at 7:28 PM, Sean Bruno <sbruno@freebsd.org> wrote:
> > Author: sbruno
> > Date: Wed Dec  4 00:28:44 2013
> > New Revision: 258901
> > URL: http://svnweb.freebsd.org/changeset/base/258901
> >
> > Log:
> >   svn r251516 resized the buf argument a bit too much.  Pass a hardcoded
> >   size of 6 to humanize_number() to resolve this.
> 
> Where is the value of 6 derived from?

It was the old size of buf.  It's a value that allows humanize_number always 
use the largest 2^(10*n) unit.

-- 
John Baldwin