From owner-svn-src-all@freebsd.org  Sun Oct  4 09:46:55 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E71F3A0FF23;
 Sun,  4 Oct 2015 09:46:55 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7A04B1ACA;
 Sun,  4 Oct 2015 09:46:55 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kostik@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id t949knRZ089742
 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Sun, 4 Oct 2015 12:46:50 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua t949knRZ089742
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id t949knYg089741;
 Sun, 4 Oct 2015 12:46:49 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Sun, 4 Oct 2015 12:46:49 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: dumbbell@freebsd.org, s3erios@gmail.com
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r288653 - in head/sys/dev/drm2: . i915
Message-ID: <20151004094649.GG11284@kib.kiev.ua>
References: <201510040745.t947jbp7082807@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201510040745.t947jbp7082807@repo.freebsd.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Oct 2015 09:46:56 -0000

On Sun, Oct 04, 2015 at 07:45:37AM +0000, Adrian Chadd wrote:
>   * Add missing case statement (gen == 3) in intel_gpu_reset().
This seems to be wrong.  The i915 and G33 chipsets do not have registers
declared in the 8xx chipset documentation.  More, i915 and G33 have different
reset procedures.

The absence of '3' case was copied from the corresponding Linux kernel.
Was this change tested, or is there a reference to upstream where the
handling was added in this manner ?


>   * Replace M_WAITOK with M_NOWAIT when the return value of malloc is checked (may be incorrect).
This is also incorrect.  At least the modesetting pathes are executed in
the syscall context, and sleeping is allowed; the modesetting locks were
selected to make sleeping possible.  Using nowait causes random syscalls
failure where the requests would succeed otherwise.