From owner-svn-src-head@freebsd.org Tue Jul 14 20:46:08 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 70C119A16C3; Tue, 14 Jul 2015 20:46:08 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x236.google.com (mail-wi0-x236.google.com [IPv6:2a00:1450:400c:c05::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 18633204C; Tue, 14 Jul 2015 20:46:08 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by widjy10 with SMTP id jy10so110279706wid.1; Tue, 14 Jul 2015 13:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=ieWW4Y++NP+HkXSOrObdLu2prE6XXfgK+auHGvQGknM=; b=quaIzjtct2wKJf2bezRmqy0ucZ9WTgEEpTEntrehG0bLyuDx58uK0zIgDyiNdJSo3B z49+PxuYxDbVzll6/uRfkhj3+5tYu3p4IbkXfFZmrJqwPavopfz9eapiB7LXny1zAcmT eXjWo+lAk1eK3w1x9exP1LHVt5KOHzevZ8T40JRBrC/znvdMVqgmnRyllCXuuIWauzUc Kmrl8CAzS6tXQJLGW1umZCNGOz/4kdeyDz3KGbYzs2EkEYExPmU6RtNtG+Jt4O9xW43+ wPTWWuh5AKsGct0tCzu8W6P/++EPx4XYYj8WDD79DqNUztU1u4XHsQF4bIrJwgereKGr 9leA== X-Received: by 10.194.110.100 with SMTP id hz4mr1057640wjb.6.1436906766371; Tue, 14 Jul 2015 13:46:06 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id lj14sm5227838wic.18.2015.07.14.13.46.05 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Jul 2015 13:46:05 -0700 (PDT) Sender: Baptiste Daroussin Date: Tue, 14 Jul 2015 22:46:03 +0200 From: Baptiste Daroussin To: Garrett Cooper Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers Subject: Re: svn commit: r285552 - head/usr.bin/xargs Message-ID: <20150714204603.GO37597@ivaldir.etoilebsd.net> References: <201507141916.t6EJGEG1083928@repo.freebsd.org> <48222CD1-7087-4C9A-A586-71F6A37A601C@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yPSgZSQ6mfPWgZ9n" Content-Disposition: inline In-Reply-To: <48222CD1-7087-4C9A-A586-71F6A37A601C@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2015 20:46:08 -0000 --yPSgZSQ6mfPWgZ9n Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 14, 2015 at 01:29:20PM -0700, Garrett Cooper wrote: > On Jul 14, 2015, at 12:16, Baptiste Daroussin wrote: >=20 > > Author: bapt > > Date: Tue Jul 14 19:16:14 2015 > > New Revision: 285552 > > URL: https://svnweb.freebsd.org/changeset/base/285552 > >=20 > > Log: > > Convert atoi(3) to stronum(3) which allows to arguments and report pro= per errors > > to the users >=20 > Is strtonum preferred over strtoll, etc? I do personnaly prefer strtonum over strtoll, so I usually use it. in that particular case of xargs I haven't chosen it, I just run into the issue due= to atoi an looked at others BSDs to see if they had fixed the issue. OpenBSD h= ad this fixed so I just grabbed it so not reinvent wheel. Bapt --yPSgZSQ6mfPWgZ9n Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlWldQsACgkQ8kTtMUmk6Ez+TwCggL4xoU8DbGB0h9c3w//h+mMG gIYAn3oPnnOnmtLRA7fHbm95qbuMCa7b =Jlio -----END PGP SIGNATURE----- --yPSgZSQ6mfPWgZ9n--