From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Dec 31 09:10:18 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 184FB16A407 for ; Sun, 31 Dec 2006 09:10:18 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id B8B2713C428 for ; Sun, 31 Dec 2006 09:10:17 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id kBV9AHSA098601 for ; Sun, 31 Dec 2006 09:10:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id kBV9AHPc098598; Sun, 31 Dec 2006 09:10:17 GMT (envelope-from gnats) Date: Sun, 31 Dec 2006 09:10:17 GMT Message-Id: <200612310910.kBV9AHPc098598@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: "Jonathan Liu" Cc: Subject: Re: ports/107368: [ports] [normalize] [patch] - normalize-mp3 and normalize-ogg don't work X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Jonathan Liu List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Dec 2006 09:10:18 -0000 The following reply was made to PR ports/107368; it has been noted by GNATS. From: "Jonathan Liu" To: , Cc: Subject: Re: ports/107368: [ports] [normalize] [patch] - normalize-mp3 and normalize-ogg don't work Date: Sun, 31 Dec 2006 19:53:25 +1100 This is a multi-part message in MIME format. ------=_NextPart_000_0005_01C72D15.557B3710 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit It appears that the port does a compile-time check for available programs to use and sets the encoder and decoder programs accordingly in the normalize-mp3 Perl script. This functionality however, seems somewhat broken. Run-time detection of encoders and decoders should be used instead. The following patch updates the Makefile for the port to use run-time detection of encoders and decoders (please disregard originally submitted patch when using this patch): --- Makefile.orig Mon Jan 30 23:33:07 2006 +++ Makefile Sun Dec 31 19:44:27 2006 @@ -29,12 +29,14 @@ .include +CONFIGURE_ARGS+=--disable-helper-search + .if defined(WITH_XMMS) LIB_DEPENDS+= xmms.4:${PORTSDIR}/multimedia/xmms PLIST_SUB+= XMMS="" PLIST_SUB+= X11BASE="${X11BASE}" .else -CONFIGURE_ARGS= --disable-xmms +CONFIGURE_ARGS+=--disable-xmms PLIST_SUB+= XMMS="@comment " .endif ------=_NextPart_000_0005_01C72D15.557B3710 Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

It appears that the port does a compile-time check = for available programs to use and sets the encoder and decoder programs = accordingly in the normalize-mp3 Perl script. This functionality however, seems = somewhat broken. Run-time detection of encoders and decoders should be used = instead. The following patch updates the Makefile for the port to use run-time = detection of encoders and decoders (please disregard originally submitted patch when = using this patch):

--- Makefile.orig Mon Jan 30 23:33:07 = 2006

+++ Makefile Sun Dec 31 = 19:44:27 2006

@@ -29,12 +29,14 @@

.include = <bsd.port.pre.mk>

+CONFIGURE_ARGS+=3D--disable-helper-search<= /span>

.if = defined(WITH_XMMS)

LIB_DEPENDS+=3D &nb= sp; = xmms.4:${PORTSDIR}/multimedia/xmms

PLIST_SUB+=3D = XMMS=3D""

PLIST_SUB+=3D = X11BASE=3D"${X11BASE}"

.else

-CONFIGURE_ARGS=3D = --disable-xmms

+CONFIGURE_ARGS+=3D--disable-xmms

PLIST_SUB+=3D XMMS=3D"@comment = "

.endif

------=_NextPart_000_0005_01C72D15.557B3710--