Date: Thu, 18 Aug 2016 07:56:55 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 211958] Boot overflows when reading loader.conf Message-ID: <bug-211958-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211958 Bug ID: 211958 Summary: Boot overflows when reading loader.conf Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: ecturt@gmail.com There are some overflows when reading loader.conf, for example if you add a line like: autoboot aaaaaaaaa... It will overflow a 256 byte buffer here: https://github.com/freebsd/freebsd/blob/af3e10e5a78d3af8cef6088748978c6c612= 757f0/sys/boot/common/boot.c#L132 https://github.com/freebsd/freebsd/blob/7fc7d2ed6e06340ab861cd094a78db87215= ecff3/sys/boot/common/commands.c#L36 This sprintf pattern into command_errbuf seems to be repeated a lot, and sh= ould probably be replaced with slprintf. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-211958-8>