From owner-cvs-src@FreeBSD.ORG Sun Oct 30 17:59:30 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 24B5416A41F; Sun, 30 Oct 2005 17:59:30 +0000 (GMT) (envelope-from nate@root.org) Received: from ylpvm12.prodigy.net (ylpvm12-ext.prodigy.net [207.115.57.43]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7251043D48; Sun, 30 Oct 2005 17:59:28 +0000 (GMT) (envelope-from nate@root.org) Received: from ylpvm01.prodigy.net (ylpvm01-int.prodigy.net [207.115.5.207]) by ylpvm12.prodigy.net (8.12.10 outbound/8.12.10) with ESMTP id j9UHxqil003032; Sun, 30 Oct 2005 12:59:52 -0500 X-ORBL: [71.139.0.107] Received: from [10.0.0.115] (ppp-71-139-0-107.dsl.snfc21.pacbell.net [71.139.0.107]) by ylpvm01.prodigy.net (8.13.4 dk-milter linux/8.13.4) with ESMTP id j9UI3WU7013267; Sun, 30 Oct 2005 13:03:32 -0500 Message-ID: <436509D5.3020401@root.org> Date: Sun, 30 Oct 2005 09:58:45 -0800 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (X11/20050723) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Ceri Davies References: <200510271734.j9RHYZAk015054@repoman.freebsd.org> <20051030062148.GA76667@dragon.NUXI.org> <20051030105647.GR99857@submonkey.net> In-Reply-To: <20051030105647.GR99857@submonkey.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-all@FreeBSD.org, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, John Baldwin , David O'Brien Subject: Re: cvs commit: src/sys/i386/conf DEFAULTS GENERIC X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Oct 2005 17:59:30 -0000 Ceri Davies wrote: > On Sat, Oct 29, 2005 at 11:21:48PM -0700, David O'Brien wrote: > >>On Thu, Oct 27, 2005 at 05:34:35PM +0000, John Baldwin wrote: >> >>>jhb 2005-10-27 17:34:35 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/i386/conf GENERIC >>> Added files: >>> sys/i386/conf DEFAULTS >>> Log: >>> Create a default kernel config for i386 and move 'device isa' and >>> 'device npx' (both of which aren't really optional right now) and >>> 'device io' and 'device mem' (to preserve POLA for 4.x users upgrading >>> to 6.0) from GENERIC into DEFAULTS. >> >>I may be missing something. I don't quite follow the benefit of the new >>'DEFAULTS' file. I'm also curious why we don't explicitly 'include' >>DEFAULTS in GENERIC vs. the new automagic include feature. > > > I was also confused by that. There are also no warnings if DEFAULTS is > missing, which means that by removing a seemingly unrelated file I get a > different (read: useless to me) kernel. Does INCLUDE_CONFIG_FILE show > the contents of DEFAULTS as well? A better way would be to make io and mem only compile time options (default to on). There is no benefit to them being modules. Anyone who wants to compile with NO_DEVIO or NO_DEVMEM will know why their kernel stops working. -- Nate