From owner-freebsd-bugs@FreeBSD.ORG Mon Jan 16 21:10:03 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB90616A41F for ; Mon, 16 Jan 2006 21:10:03 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3282B43D46 for ; Mon, 16 Jan 2006 21:10:03 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k0GLA3Tg033872 for ; Mon, 16 Jan 2006 21:10:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k0GLA3ud033867; Mon, 16 Jan 2006 21:10:03 GMT (envelope-from gnats) Resent-Date: Mon, 16 Jan 2006 21:10:03 GMT Resent-Message-Id: <200601162110.k0GLA3ud033867@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Balázs Nagy Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BD1D716A41F for ; Mon, 16 Jan 2006 21:07:50 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4C05643D58 for ; Mon, 16 Jan 2006 21:07:50 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k0GL7n9p066448 for ; Mon, 16 Jan 2006 21:07:49 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id k0GL7nEY066447; Mon, 16 Jan 2006 21:07:49 GMT (envelope-from nobody) Message-Id: <200601162107.k0GL7nEY066447@www.freebsd.org> Date: Mon, 16 Jan 2006 21:07:49 GMT From: Balázs Nagy To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: misc/91883: www/apache20 doesn't compile on 5.4.1 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2006 21:10:03 -0000 >Number: 91883 >Category: misc >Synopsis: www/apache20 doesn't compile on 5.4.1 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jan 16 21:10:02 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Balázs Nagy >Release: 5.4-RELEASE-p9 >Organization: >Environment: FreeBSD tcb.aranyoroszlan.hu 5.4-RELEASE-p9 FreeBSD 5.4-RELEASE-p9 #0: Sun Jan 15 22:13:08 CET 2006 root@tcb.aranyoroszlan.hu:/opt/devel/obj/opt/devel/src/sys/SAMU i386 >Description: The following patch (ports/www/apache20/Makefile:1.232) breaks the compatibility with 5.4 -WITH_PTHREAD_LIBS?= ${PTHREAD_LIBS:S/-l//:S/-//} -WITH_PTHREAD_CFLAGS?= ${PTHREAD_CFLAGS} .. +.if defined(WITH_THREADS) +CONFIGURE_ARGS+= --enable-threads +. if ${OSVERSION} > 500023 +CONFIGURE_ENV+= apr_cv_pthreads_lib=-l${WITH_PTHREAD_LIBS} \ + apr_cv_pthreads_cflags=${WITH_PTHREAD_CFLAGS} +. if ${ARCH} == i386 +CONFIGURE_ARGS+= --enable-nonportable-atomics +. endif +. else +CFLAGS+= -DFREEBSD_THREAD_HACK +. endif +.endif It used to define WITH_PTHREAD_LIBS and WITH_PTHREAD_CFLAGS, but they don't accessible anymore. Moreover, it breaks configure because of the bare '-l'. >How-To-Repeat: >Fix: AFAIK ports/Mk/bsd.ports.mk knows better how to use threading libraries. I suggest to use .if defined(WITH_THREADS) CONFIGURE_ARGS+= --enable-threads CONFIGURE_ENV+= apr_cv_pthreads_lib=${PTHREAD_LIBS} \ apr_cv_pthreads_cflags=${PTHREAD_CFLAGS} .. because PTHREAD_LIBS and PTHREAD_CFLAGS are always defined. >Release-Note: >Audit-Trail: >Unformatted: