From owner-freebsd-bugs@FreeBSD.ORG Tue Sep 7 07:20:20 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D2E0516A4D2 for ; Tue, 7 Sep 2004 07:20:20 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9D30343D49 for ; Tue, 7 Sep 2004 07:20:20 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i877KK3Q067126 for ; Tue, 7 Sep 2004 07:20:20 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i877KKed067125; Tue, 7 Sep 2004 07:20:20 GMT (envelope-from gnats) Resent-Date: Tue, 7 Sep 2004 07:20:20 GMT Resent-Message-Id: <200409070720.i877KKed067125@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dmitri Nikulin Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C548016A4CF for ; Tue, 7 Sep 2004 07:10:57 +0000 (GMT) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id B64E543D41 for ; Tue, 7 Sep 2004 07:10:57 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i877Av9W096282 for ; Tue, 7 Sep 2004 07:10:57 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.12.11/8.12.11/Submit) id i877AvOh096280; Tue, 7 Sep 2004 07:10:57 GMT (envelope-from nobody) Message-Id: <200409070710.i877AvOh096280@www.freebsd.org> Date: Tue, 7 Sep 2004 07:10:57 GMT From: Dmitri Nikulin To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: kern/71449: sys/compat/ndis Compilation warnings X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Sep 2004 07:20:20 -0000 >Number: 71449 >Category: kern >Synopsis: sys/compat/ndis Compilation warnings >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Sep 07 07:20:19 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Dmitri Nikulin >Release: 5.3-BETA3 >Organization: >Environment: FreeBSD dirk.vic.optushome.com.au 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Mon Sep 6 23:44:48 EST 2004 root@dirk.vic.optushome.com.au:/usr/obj/home/bsd/src/sys/KERN i386 >Description: Oversights in casting when __stdcall isn't meaningless cause warnings, which, when compiled into the kernel via options NDISAPI and no removal of -werror, kill a kernel compile. >How-To-Repeat: 'options NDISAPI' in kernel config Compile kernel normally >Fix: Relative to src/sys/compat: diff -ruN ndis/subr_ndis.c ndis.new/subr_ndis.c --- ndis/subr_ndis.c Tue Aug 17 05:25:27 2004 +++ ndis.new/subr_ndis.c Tue Sep 7 17:04:58 2004 @@ -2875,7 +2875,7 @@ __stdcall ndis_proc workfunc; work = ctx; - workfunc = work->nwi_func; + workfunc = (__stdcall ndis_proc) work->nwi_func; workfunc(work, work->nwi_ctx); return; } diff -ruN ndis/subr_ntoskrnl.c ndis.new/subr_ntoskrnl.c --- ndis/subr_ntoskrnl.c Tue Aug 17 04:52:37 2004 +++ ndis.new/subr_ntoskrnl.c Tue Sep 7 17:05:27 2004 @@ -1694,7 +1694,7 @@ uint8_t irql; dpc = arg; - dpcfunc = (kdpc_func)dpc->k_deferedfunc; + dpcfunc = (__stdcall kdpc_func) dpc->k_deferedfunc; irql = ntoskrnl_raise_irql(DISPATCH_LEVEL); dpcfunc(dpc, dpc->k_deferredctx, dpc->k_sysarg1, dpc->k_sysarg2); ntoskrnl_lower_irql(irql); >Release-Note: >Audit-Trail: >Unformatted: