Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 03 Jun 2015 15:43:46 -0700
From:      Xin Li <delphij@delphij.net>
To:        Baptiste Daroussin <bapt@freebsd.org>,  Sergey Kandaurov <pluknet@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org,  src-committers@freebsd.org, nectar@FreeBSD.org
Subject:   Re: svn commit: r283969 - head/lib/libutil
Message-ID:  <556F8322.9050602@delphij.net>
In-Reply-To: <20150603215841.GF32562@ivaldir.etoilebsd.net>
References:  <201506032048.t53KmSCf074619@svn.freebsd.org> <CAE-mSOLvc-ofOw7wMXBNqufePJHzJOyRjD2hYFnJKfp2%2BJDKTw@mail.gmail.com> <20150603215841.GF32562@ivaldir.etoilebsd.net>

next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 06/03/15 14:58, Baptiste Daroussin wrote:
> On Thu, Jun 04, 2015 at 12:51:46AM +0300, Sergey Kandaurov wrote:
>> On 3 June 2015 at 23:48, Baptiste Daroussin <bapt@freebsd.org>
>> wrote:
>>> Author: bapt Date: Wed Jun  3 20:48:28 2015 New Revision:
>>> 283969 URL: https://svnweb.freebsd.org/changeset/base/283969
>>> 
>>> Log: Add a pw_mkdb2(3) function which does the same thing as
>>> pw_mkdb(3) except it takes a new argument allowing to specify
>>> the endianness of the database to generate
>>> 
>> 
>> Why not change pw_mkdb()? Is it used outside of the project?
>> 
> Because that would change the ABI of libutil and it is not a
> private library aka we are supposed to maintain ABI compatibility
> as we do not know if it is used or not externally to the project. I
> care about the ABI because I have made this change in order to use
> it in pw(8) and MFC it to stable/10 before 10.2.
> 
> libutil is not versionned so this is the only way to not break the
> ABI. Except if someone has a better idea than I do.

Looking at r113596, pwd_mkdb(8) was changed to generate both legacy
(version 3, endianness sensitive) and new (version 4, machine
independent) formats.

Now, after 12 years, is it still sensible to generate legacy format db
entries?  Maybe we should just disable the generation by default and
eventually remove the ability to generate them?

Cheers,
- -- 
Xin LI <delphij@delphij.net>    https://www.delphij.net/
FreeBSD - The Power to Serve!           Live free or die
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.1.4 (FreeBSD)

iQIcBAEBCgAGBQJVb4MYAAoJEJW2GBstM+nsUqAP/1VTYSVd4CvhepOd6uEoi6YG
616V2X6vNNA11BKK7AHWjSIydzwpg1GNrEUeSUwoU7vCzNAsU0zIjYWK2Vfl30ru
PFjtuDlJwU3z5qhYtLlBOoSMQk+0LDJ0t8SSeaaXNO589t+66B+USSJk1YvTGOB8
KkkLq20Y+C+VyVEQ76I/RExJE5aJSvtUgN4+po+Ic8iZHhSWPJoe7XsHK/L/R/QZ
WJuGQe7qmbpfi1j1wHdGRpdtYzZolwvc8Z6RHNhIA7h5m83wdR0zOgtH/RlFAtn8
4IBd2V0YCBTz6nrRav1lSo/tXGrKTFzoM6ij+Sjl4k2IQXsc/DkIpV9XUJH4oQBF
mhJlNP7BxomUlb2J6anqfdh3+ni3Rpx3FN+77lAMe1IWolbEwJkXsVZDUDZ8O4Ik
QF+qa+lY4aFR83ZNq9AG0aU7/UdoX0+COr0VJ0SwYk/DgpmGOqhxLnOMyWdWehLm
kIeJkZPySGNGqnqUISfSRxjKXns7CqfGEuRMO6ED2m+x0Tg4KMmklnjnMPG4H8hv
qbt4ALynIeuaGIG7oCrc1EXw5XbrMrPeU2mIA+82uqAGgsQdYngFi4vzr3kp7CkK
yLKxlFuPrQ6QS9uJI1/MhCDpXff+GzJGE5R22QgFsLNiQemDfvjVcne4ZBBTwWI7
S78XZWGwJihSGp0XgDAd
=4wxs
-----END PGP SIGNATURE-----



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?556F8322.9050602>