From owner-svn-src-head@FreeBSD.ORG Wed Jun 3 22:43:47 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A1FE8EB9; Wed, 3 Jun 2015 22:43:47 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "anubis.delphij.net", Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 87EA91301; Wed, 3 Jun 2015 22:43:47 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from zeta.ixsystems.com (unknown [12.229.62.2]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by anubis.delphij.net (Postfix) with ESMTPSA id 0E82017078; Wed, 3 Jun 2015 15:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=delphij.net; s=anubis; t=1433371427; x=1433385827; bh=WWgXDwHXfjfuLUPJe1I3yZKLXrD4XQ5T10UnFQyr+VA=; h=Date:From:Reply-To:To:CC:Subject:References:In-Reply-To; b=C8JdP6Z6C+JKUdlQjCx7RxwaXRJfl9vB5Cuo7wAYrDfqoRzeuY5oMiuJ0byOR3Vg4 FEqZZ6P+kd6gxcRYJG7ulT9OQgBflT+mXP2HczcN7DN6OHYwX+wcrAP2QA0XAkeKW/ NGidPD6Lm4nvTvMmCUWWYhPzXsn2VLEQrsW0IOG8= Message-ID: <556F8322.9050602@delphij.net> Date: Wed, 03 Jun 2015 15:43:46 -0700 From: Xin Li Reply-To: d@delphij.net Organization: The FreeBSD Project MIME-Version: 1.0 To: Baptiste Daroussin , Sergey Kandaurov CC: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, nectar@FreeBSD.org Subject: Re: svn commit: r283969 - head/lib/libutil References: <201506032048.t53KmSCf074619@svn.freebsd.org> <20150603215841.GF32562@ivaldir.etoilebsd.net> In-Reply-To: <20150603215841.GF32562@ivaldir.etoilebsd.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jun 2015 22:43:47 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 06/03/15 14:58, Baptiste Daroussin wrote: > On Thu, Jun 04, 2015 at 12:51:46AM +0300, Sergey Kandaurov wrote: >> On 3 June 2015 at 23:48, Baptiste Daroussin >> wrote: >>> Author: bapt Date: Wed Jun 3 20:48:28 2015 New Revision: >>> 283969 URL: https://svnweb.freebsd.org/changeset/base/283969 >>> >>> Log: Add a pw_mkdb2(3) function which does the same thing as >>> pw_mkdb(3) except it takes a new argument allowing to specify >>> the endianness of the database to generate >>> >> >> Why not change pw_mkdb()? Is it used outside of the project? >> > Because that would change the ABI of libutil and it is not a > private library aka we are supposed to maintain ABI compatibility > as we do not know if it is used or not externally to the project. I > care about the ABI because I have made this change in order to use > it in pw(8) and MFC it to stable/10 before 10.2. > > libutil is not versionned so this is the only way to not break the > ABI. Except if someone has a better idea than I do. Looking at r113596, pwd_mkdb(8) was changed to generate both legacy (version 3, endianness sensitive) and new (version 4, machine independent) formats. Now, after 12 years, is it still sensible to generate legacy format db entries? Maybe we should just disable the generation by default and eventually remove the ability to generate them? Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.1.4 (FreeBSD) iQIcBAEBCgAGBQJVb4MYAAoJEJW2GBstM+nsUqAP/1VTYSVd4CvhepOd6uEoi6YG 616V2X6vNNA11BKK7AHWjSIydzwpg1GNrEUeSUwoU7vCzNAsU0zIjYWK2Vfl30ru PFjtuDlJwU3z5qhYtLlBOoSMQk+0LDJ0t8SSeaaXNO589t+66B+USSJk1YvTGOB8 KkkLq20Y+C+VyVEQ76I/RExJE5aJSvtUgN4+po+Ic8iZHhSWPJoe7XsHK/L/R/QZ WJuGQe7qmbpfi1j1wHdGRpdtYzZolwvc8Z6RHNhIA7h5m83wdR0zOgtH/RlFAtn8 4IBd2V0YCBTz6nrRav1lSo/tXGrKTFzoM6ij+Sjl4k2IQXsc/DkIpV9XUJH4oQBF mhJlNP7BxomUlb2J6anqfdh3+ni3Rpx3FN+77lAMe1IWolbEwJkXsVZDUDZ8O4Ik QF+qa+lY4aFR83ZNq9AG0aU7/UdoX0+COr0VJ0SwYk/DgpmGOqhxLnOMyWdWehLm kIeJkZPySGNGqnqUISfSRxjKXns7CqfGEuRMO6ED2m+x0Tg4KMmklnjnMPG4H8hv qbt4ALynIeuaGIG7oCrc1EXw5XbrMrPeU2mIA+82uqAGgsQdYngFi4vzr3kp7CkK yLKxlFuPrQ6QS9uJI1/MhCDpXff+GzJGE5R22QgFsLNiQemDfvjVcne4ZBBTwWI7 S78XZWGwJihSGp0XgDAd =4wxs -----END PGP SIGNATURE-----