From owner-svn-ports-all@FreeBSD.ORG  Tue Aug 28 19:13:14 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 886541065670;
	Tue, 28 Aug 2012 19:13:14 +0000 (UTC)
	(envelope-from madpilot@FreeBSD.org)
Received: from micro.madpilot.net (micro.madpilot.net [88.149.173.206])
	by mx1.freebsd.org (Postfix) with ESMTP id C3F6B8FC12;
	Tue, 28 Aug 2012 19:13:13 +0000 (UTC)
Received: from micro.madpilot.net (localhost [127.0.0.1])
	by micro.madpilot.net (Postfix) with ESMTP id 3X603r34LPz2Ds;
	Tue, 28 Aug 2012 21:13:12 +0200 (CEST)
X-Virus-Scanned: amavisd-new at madpilot.net
Received: from micro.madpilot.net ([127.0.0.1])
	by micro.madpilot.net (micro.madpilot.net [127.0.0.1]) (amavisd-new,
	port 10024)
	with ESMTP id CMP4Tqg0iJL8; Tue, 28 Aug 2012 21:13:09 +0200 (CEST)
Received: from marvin.madpilot.net (localhost [127.0.0.1])
	by micro.madpilot.net (Postfix) with ESMTP;
	Tue, 28 Aug 2012 21:13:09 +0200 (CEST)
Message-ID: <503D1845.4090509@FreeBSD.org>
Date: Tue, 28 Aug 2012 21:13:09 +0200
From: Guido Falsi <madpilot@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:14.0) Gecko/20120727 Thunderbird/14.0
MIME-Version: 1.0
To: Alexey Dokuchaev <danfe@FreeBSD.org>
References: <201208281203.q7SC3jU7063943@svn.freebsd.org>
	<20120828145248.GC87067@FreeBSD.org>
In-Reply-To: <20120828145248.GC87067@FreeBSD.org>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
	ports-committers@freebsd.org, Chris Rees <crees@FreeBSD.org>,
	Thomas Abthorpe <tabthorpe@FreeBSD.org>, Tijl Coosemans <tijl@freebsd.org>
Subject: Re: svn commit: r303278 - in head/games/simutrans: . files
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
	<mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
	<mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Aug 2012 19:13:14 -0000

On 08/28/12 16:52, Alexey Dokuchaev wrote:
> On Tue, Aug 28, 2012 at 12:03:45PM +0000, Guido Falsi wrote:
>> New Revision: 303278
>> URL: http://svn.freebsd.org/changeset/ports/303278
>>
>> -	${INSTALL_DATA} ${FILESDIR}/simutrans.desktop \
>> +	${INSTALL_SCRIPT} ${FILESDIR}/simutrans.desktop \
>>   		${PREFIX}/share/applications/simutrans.desktop
>
> Why does .desktop file have to have +x bit?
>

Good catch! :)

I contacted the maintainer who answered to danfe too. This followup is 
to keep others informed.

The maintainer justified this, after I contacted him pointing me here:

http://mail.kde.org/pipermail/kde-freebsd/2012-June/013233.html

in his own words:

Basically KDE counts .desktop files without +x in the user's own desktop 
as dangerous and warns about this. If a user drags an icon from system 
wide menu to the desktop it gets copied with same permissions(no +x). 
KDE people seem to think this is useful to protect from downloaded files.

Maintainer is ok to modify the port back to installing without +x if 
that's the consensus. I also have no problem modifying it if having 
.desktop files with +x is a problem.

Perhaps someone more knowledgeable about KDE than me could also comment 
on this.

-- 
Guido Falsi <madpilot@FreeBSD.org>