From owner-svn-src-head@FreeBSD.ORG Tue Jan 13 09:16:17 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0528932F for ; Tue, 13 Jan 2015 09:16:17 +0000 (UTC) Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AE178EA1 for ; Tue, 13 Jan 2015 09:16:16 +0000 (UTC) Received: by mail-we0-f177.google.com with SMTP id q59so1635759wes.8 for ; Tue, 13 Jan 2015 01:16:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=sc5Brqph9AIcJJlN/9BvN7hNGRfGyNm3BKm9kcyQS0U=; b=kYi2Cj4xWknty2G/MFbNuMhGhmcVfVcKtwZcSiDEN2OtBGLUuaLP/5ylvfGte17VfT WwANeMgae2c5AB4OZxvGwG6XUANmIw3VgGS8bwBI4FvNDnPWfgfJ4HzX/nRVNDhhA6gy jiLIM9FiQW+Y91sXRy4/rM+fLLty0NPi/epyqjlPGKeO1+59Rboozbf54nzi7Qr291Su FawU57cJald9iAhrsvKhMNCE6KlbR0Z+yQtPEwDkBPfPnY6K4OG2m3yOh3JdUC64jRmv m+kFpOR0o7mxYUCM1qHl0uM6sMhYhHL4YXC03y03njpVx2Qms+40wwICB5D0KcuSFxaV 38pg== X-Gm-Message-State: ALoCoQl0y0GmF6nPcs6CuwrMUVNIFweyGL+8HXZjoQyDs4vQYr4cp7j5nXV5GpWPYQz4Q/wxaOsC X-Received: by 10.195.13.104 with SMTP id ex8mr14053929wjd.12.1421140569103; Tue, 13 Jan 2015 01:16:09 -0800 (PST) Received: from [10.10.1.68] (82-69-141-170.dsl.in-addr.zen.co.uk. [82.69.141.170]) by mx.google.com with ESMTPSA id i15sm24873299wjq.22.2015.01.13.01.16.08 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Jan 2015 01:16:08 -0800 (PST) Message-ID: <54B4E24D.9070305@multiplay.co.uk> Date: Tue, 13 Jan 2015 09:15:57 +0000 From: Steven Hartland User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Konstantin Belousov Subject: Re: svn commit: r277100 - head/sys/dev/ahci References: <201501130011.t0D0BvRD026054@svn.freebsd.org> <54B472FC.4090808@freebsd.org> <20150113082012.GI42409@kib.kiev.ua> In-Reply-To: <20150113082012.GI42409@kib.kiev.ua> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jan 2015 09:16:17 -0000 On 13/01/2015 08:20, Konstantin Belousov wrote: > On Tue, Jan 13, 2015 at 01:21:00AM +0000, Steven Hartland wrote: >> Looks like this missed the addition of the new quirk to AHCI_Q_BIT_STRING. > Thank you for noting. > > See the patch below. Is anything else amiss ? > > Index: sys/dev/ahci/ahci.h > =================================================================== > --- sys/dev/ahci/ahci.h (revision 277100) > +++ sys/dev/ahci/ahci.h (working copy) > @@ -591,7 +591,8 @@ > "\015NOMSI" \ > "\016ATI_PMP_BUG" \ > "\017MAXIO_64K" \ > - "\020SATA1_UNIT0" > + "\020SATA1_UNIT0" \ > + "\021ABAR0" > > int ahci_attach(device_t dev); > int ahci_detach(device_t dev); Yep that's the puppy, everything else looks good :)