From owner-freebsd-current Fri Jun 23 23:12: 2 2000 Delivered-To: freebsd-current@freebsd.org Received: from rover.village.org (rover.village.org [204.144.255.49]) by hub.freebsd.org (Postfix) with ESMTP id BBC6F37BB53; Fri, 23 Jun 2000 23:11:57 -0700 (PDT) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.9.3/8.9.3) with ESMTP id AAA58066; Sat, 24 Jun 2000 00:11:55 -0600 (MDT) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id AAA01831; Sat, 24 Jun 2000 00:10:15 -0600 (MDT) Message-Id: <200006240610.AAA01831@harmony.village.org> To: Assar Westerlund Subject: Re: vnode_if.h: how should it be done ? Cc: Garrett Wollman , current@FreeBSD.ORG, kris@FreeBSD.ORG In-reply-to: Your message of "22 Jun 2000 05:57:01 +0200." <5llmzyqsfm.fsf@assaris.sics.se> References: <5llmzyqsfm.fsf@assaris.sics.se> <5ln1kesdkq.fsf@assaris.sics.se> <200006220345.XAA42447@khavrinen.lcs.mit.edu> Date: Sat, 24 Jun 2000 00:10:14 -0600 From: Warner Losh Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <5llmzyqsfm.fsf@assaris.sics.se> Assar Westerlund writes: : The problem is that the source files are hidden in the kernel source : directory and not installed. Where should vnode_if.{src,pl} get : installed? It seems much simpler just to install vnode_if.h in : /usr/include/sys. Patch appended. No. We don't install kenrel internal files. Use SYSDIR instead. : + ${INSTALL} -C -o ${BINOWN} -g ${BINGRP} -m 444 \ : + ${.OBJDIR}/vnode_if.h \ : + ${DESTDIR}/usr/include/sys I object to this part of the patch. We shouldn't install this file. It isn't needed by anything outside of the kernel/drivers. For drivers, it should be built automatically as part of the modules build system ala the *_if.m stuff. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message