From owner-svn-src-all@FreeBSD.ORG Mon Oct 29 14:27:44 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4F036644; Mon, 29 Oct 2012 14:27:44 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 07F888FC08; Mon, 29 Oct 2012 14:27:42 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id QAA15239; Mon, 29 Oct 2012 16:27:40 +0200 (EET) (envelope-from avg@FreeBSD.org) Message-ID: <508E925C.3010707@FreeBSD.org> Date: Mon, 29 Oct 2012 16:27:40 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:16.0) Gecko/20121014 Thunderbird/16.0.1 MIME-Version: 1.0 To: Alexander Motin Subject: Re: svn commit: r242314 - head/sys/geom/raid References: <201210291418.q9TEIsrZ078107@svn.freebsd.org> In-Reply-To: <201210291418.q9TEIsrZ078107@svn.freebsd.org> X-Enigmail-Version: 1.4.5 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2012 14:27:44 -0000 on 29/10/2012 16:18 Alexander Motin said the following: > Author: mav > Date: Mon Oct 29 14:18:54 2012 > New Revision: 242314 > URL: http://svn.freebsd.org/changeset/base/242314 > > Log: > Make GEOM RAID more aggressive in marking volumes as clean on shutdown > and move that action from shutdown_pre_sync to shutdown_post_sync stage > to avoid extra flapping. > > ZFS tends to not close devices on shutdown, that doesn't allow GEOM RAID > to shutdown gracefully. To handle that, mark volume as clean just when > shutdown time comes and there are no active writes. Perhaps something like what zfs_modevent(MOD_UNLOAD) does should also be done in one of the shutdown hooks? Maybe at the start of shutdown_post_sync (so that it is run before the hooks of lower level drivers like graid)? -- Andriy Gapon