Date: Fri, 31 Mar 2023 15:27:53 +0000 From: Lorenzo Salvadore <developer@lorenzosalvadore.it> To: Guido Falsi <madpilot@FreeBSD.org> Cc: Adam Weinberger <adamw@adamw.org>, gmarco@giovannelli.it, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: de841b40d24d - main - sysutils/xxd: New port Message-ID: <U1vLOeNrf9SD-7z3XgOXVXJH2YTkhHwVA0p_ae4AA-cpWMlKKCDkexZOL5I4E2wuY9ErSD7eB2yL9LVchyU_qK6N8y0INsaH3cfmaUKXEbE=@lorenzosalvadore.it> In-Reply-To: <55712a33-dd09-719f-c294-417facb103a0@FreeBSD.org> References: <03eb85e1-14fa-24f4-dcb3-84caeef82a24@FreeBSD.org> <440103A8-A773-4B4E-BEB1-28C49D1B9CB5@adamw.org> <55712a33-dd09-719f-c294-417facb103a0@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
------- Original Message ------- On Friday, March 31st, 2023 at 4:32 PM, Guido Falsi <madpilot@FreeBSD.org> = wrote: >=20 >=20 > On 31/03/23 16:30, Adam Weinberger wrote: >=20 > > > On Mar 31, 2023, at 10:28, Guido Falsi madpilot@freebsd.org wrote: > > >=20 > > > On 31/03/23 15:49, Adam Weinberger wrote: > > >=20 > > > > On Thu, Mar 30, 2023 at 4:45=E2=80=AFPM Guido Falsi <madpilot@freeb= sd.org mailto:madpilot@freebsd.org> wrote: > > > > The branch main has been updated by madpilot: > > > > URL: > > > > https://cgit.FreeBSD.org/ports/commit/?id=3Dde841b40d24d22ab51ad05e= d632e025903fbb41f https://cgit.FreeBSD.org/ports/commit/?id=3Dde841b40d24d2= 2ab51ad05ed632e025903fbb41f > > > > commit de841b40d24d22ab51ad05ed632e025903fbb41f > > > > Author: Guido Falsi madpilot@FreeBSD.org > > > > AuthorDate: 2023-03-30 20:42:54 +0000 > > > > Commit: Guido Falsi madpilot@FreeBSD.org > > > > CommitDate: 2023-03-30 20:42:54 +0000 > > > > sysutils/xxd: New port > > > > This is the standalone version of the xxd tool provided by vim. > > > > Submitted by: Gianmarco Giovannelli <gmarco@giovannelli.it > > > > mailto:gmarco@giovannelli.it> > > > > diff --git a/sysutils/xxd/Makefile b/sysutils/xxd/Makefile > > > > new file mode 100644 > > > > index 000000000000..378f364cf4bf > > > > --- /dev/null > > > > +++ b/sysutils/xxd/Makefile > > > > @@ -0,0 +1,26 @@ > > > > +PORTNAME=3D xxd > > > > +DISTVERSIONPREFIX=3D v > > > > +DISTVERSION=3D 9.0.1366 > > > > +CATEGORIES=3D sysutils > > > > + > > > > +MAINTAINER=3D gmarco@giovannelli.it mailto:gmarco@giovannelli.it > > > > +COMMENT=3D Hexdump and reverse hexdump utility > > > > +WWW=3D https://github.com/mew-cx/xxd https://github.com/mew-cx/xxd > > > > + > > > > +CONFLICTS_INSTALL=3D vim-[0-9]* vim-gtk2 vim-gtk3 vim-motif vim-x1= 1 > > > > + > > > > +ALL_TARGET=3D ${PORTNAME} > > > > +PORTSCOUT=3D ignore:1 > > > > +EXTRACT_AFTER_ARGS=3D --include=3D'/src/xxd' > > > > +WRKSRC_SUBDIR=3D src/xxd > > > > + > > > > +PLIST_FILES=3D bin/xxd > > > > + > > > > +USE_GITHUB=3D yes > > > > +GH_ACCOUNT=3D vim > > > > +GH_PROJECT=3D vim > > > > + > > > > +do-install: > > > > + ${INSTALL_PROGRAM} ${WRKSRC}/xxd ${STAGEDIR}${PREFIX}/bin > > > > + > > > > +.include <bsd.port.mk http://bsd.port.mk>; > > > > The WWW is odd here. The source files are coming from github.com/vi= m/vim http://github.com/vim/vim, but the WWW is for a related but unused pr= oject. > > >=20 > > > Oops, you're right. Submitter proposed to use a fork, but later I dec= ided grabbing the original vim distribution was better, I must have forgott= en updating the WWW line. > > >=20 > > > Will fix it! > > >=20 > > > > I update vim at the beginning of every month plus whenever new mino= rs are released, and whenever there are patches that it's important for us = to downstream. Rather than pinning xxd to a version that will be old litera= lly tomorrow, why not pull the DISTVERSION and distinfo from editors/vim/Ma= kefile? > > >=20 > > > That would be a good idea, but while using vim distinfo is trivial, I= 'm not sure how to import DISTVERSION from another port. Including the Make= file would override a bunch of other variables. > >=20 > > ${MAKE_CMD} -V DISTVERSION > >=20 > > :-) >=20 >=20 > Uhm I guess I need to pass it the vim makefile too so it would be: >=20 > ${MAKE_CMD} -f ../editors/vim/Makefile -V DISTVERSION >=20 > I guess. Does not look pretty, but could work. I am unsure that using a relative path will work in all contexts: I am thinking to a compilation started with "make -C" for example. An absolute path would probably be cleaner: ${MAKE_CMD} -f ${PORTSDIR}/editors/vim/Makefile -V DISTVERSION Cheers, Lorenzo Salvadore
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?U1vLOeNrf9SD-7z3XgOXVXJH2YTkhHwVA0p_ae4AA-cpWMlKKCDkexZOL5I4E2wuY9ErSD7eB2yL9LVchyU_qK6N8y0INsaH3cfmaUKXEbE=>