Date: Wed, 28 May 2003 17:05:59 +0400 (MSD) From: Igor Sysoev <is@rambler-co.ru> To: freebsd-net@freebsd.org Cc: Jonathan Lemon <jlemon@flugsvamp.com> Subject: turning off TCP_NOPUSH Message-ID: <Pine.BSF.4.21.0305281649190.50420-100000@is>
next in thread | raw e-mail | index | archive | help
The 1.53 fix http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet/tcp_usrreq.c.diff?r1=1.52&r2=1.53 always calls tcp_output() when TCP_NOPUSH is turned off. I think tcp_output() should be called only if data in the send buffer is less than MSS: tp->t_flags &= ~TF_NOPUSH; - error = tcp_output(tp); + if (so->so_snd.sb_cc < tp->t_maxseg) { + error = tcp_output(tp); + } If the pending data is bigger than MSS then it will be sent without significant delay. Igor Sysoev http://sysoev.ru/en/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0305281649190.50420-100000>