From owner-svn-src-head@freebsd.org Wed Jan 15 07:19:18 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B2653223753 for ; Wed, 15 Jan 2020 07:19:18 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47yJbn5Lg8z4Bll for ; Wed, 15 Jan 2020 07:19:17 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by mail-io1-xd34.google.com with SMTP id k24so16675649ioc.4 for ; Tue, 14 Jan 2020 23:19:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KeFNWLQnCT09FnXZIBXXsDN57SPBBnjfcPm/zG5/NJg=; b=F5Czsf5+cxJIrkzE0Ecux5CT4FTrbm1GReEjAieanJvDGy45Xz4qxD07hlwNXr2wfC +IwmB1yi2OzjsA2+UjXnA2LxTyeeSvgNbuoBspwGLvPfdFhbs4JFNn0dCa18/9m0fqiH Ewp3yW0vxJ7vzvw9ZhkxE827joSRB3Woaqa98NKFxh+EQ4Ty8jhwiSH3gmrq3uWDd5Ik DI32mMr15Hz5vgtKGpRfGGImeVRHs9U/pgKWcOtrpYGa2p9lqSqjw8+g1NO0YfsqLLNN 24EDfQinmXraW9Ax8FtCYbUjF5HEqaUqrQrtlWI9KlPRgBdopcyxW4zP78uQsZTn9aGH Q1Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KeFNWLQnCT09FnXZIBXXsDN57SPBBnjfcPm/zG5/NJg=; b=ID6FxF227GJAnk1PmE5i/A98MqBkCABrVGfxOq4zYTkgsxekSOAgvmpeeJmydegyZ6 7uCwD66kkIsZBF+HRAr1MFhKniEJbK25J6Rwl+gYMtCcnU4xtv0wEeh1fekC60LqZriS vohDgOBzKtTUqOAUgBFxIFUwiYyWYNK08iSf3g0vLBV8ctiN4iCMoB+YdnOOqx1ggN6W 9Jr4Hk/DUYXJhuE3xkQklshTb7LN/cm8uV98WyZHOQ6LEf3xSq0lTnUeTtnEllkpce/c eGmCpgQdKwH0+YIZuGM4bjfNqBfkbP1+3aTPtmZFeeieDtGFQ39M+Frb4H7ESLa6Sobv 74Bg== X-Gm-Message-State: APjAAAX0fprDP+EtJPA/oCd8G0clOml0yvpe3qm3d5tUTmtbE3nA6o1x UUFAM+xDFcpLARb7ImnaBjawWwnVXxXxJctpBX5Rzg== X-Google-Smtp-Source: APXvYqwwp9VrrpK84f+MRsBIhuwNQPDRq6MmOHNYmt66NlPpmpMMcxBnl2guXaOTUl7yqCvH5JK8Gd65B9K5eylLJMM= X-Received: by 2002:a5d:840a:: with SMTP id i10mr20968402ion.225.1579072756239; Tue, 14 Jan 2020 23:19:16 -0800 (PST) MIME-Version: 1.0 References: <202001150605.00F65Kc8011526@repo.freebsd.org> <20200115061046.GR39529@FreeBSD.org> In-Reply-To: <20200115061046.GR39529@FreeBSD.org> From: Steven Hartland Date: Wed, 15 Jan 2020 07:19:05 +0000 Message-ID: Subject: Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys To: Gleb Smirnoff Cc: bz@freebsd.org, cem@freebsd.org, hselasky@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 47yJbn5Lg8z4Bll X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=multiplay-co-uk.20150623.gappssmtp.com header.s=20150623 header.b=F5Czsf5+; dmarc=pass (policy=none) header.from=multiplay.co.uk; spf=pass (mx1.freebsd.org: domain of steven@multiplay.co.uk designates 2607:f8b0:4864:20::d34 as permitted sender) smtp.mailfrom=steven@multiplay.co.uk X-Spamd-Result: default: False [-4.55 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[multiplay-co-uk.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[multiplay-co-uk.20150623.gappssmtp.com:+]; DMARC_POLICY_ALLOW(-0.50)[multiplay.co.uk,none]; RCVD_IN_DNSWL_NONE(0.00)[4.3.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCPT_COUNT_SEVEN(0.00)[7]; FORGED_SENDER(0.30)[steven.hartland@multiplay.co.uk,steven@multiplay.co.uk]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-1.85)[ip: (-5.28), ipnet: 2607:f8b0::/32(-2.09), asn: 15169(-1.83), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[steven.hartland@multiplay.co.uk,steven@multiplay.co.uk]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jan 2020 07:19:18 -0000 Aren=E2=80=99t the current and suggested the same there or do I need more c= offee this morning? On Wed, 15 Jan 2020 at 06:10, Gleb Smirnoff wrote: > Hi, > > On Wed, Jan 15, 2020 at 06:05:20AM +0000, Gleb Smirnoff wrote: > T> Log: > T> Introduce NET_EPOCH_CALL() macro and use it everywhere where we free > T> data based on the network epoch. The macro reverses the argument > T> order of epoch_call(9) - first function, then its argument. NFC > > I really want to reverse the argument order of epoch_call() as well. > The current order is really backwards: > > void > epoch_call(epoch_t epoch, epoch_context_t ctx, > void (*callback)(epoch_context_t)); > > Suggested declaration is: > > void > epoch_call(epoch_t epoch, epoch_context_t ctx, > void (*callback)(epoch_context_t)); > > This will be a very easy change, since today function is > used just in few places. > > Before branching stable/12 we intentionally put this > note in epoch.9 manual page: > > NOTES > The epoch kernel programming interface is under development and is > subject to change. > > Any objections? > > -- > Gleb Smirnoff >