From owner-svn-soc-all@freebsd.org  Mon Nov 30 22:15:00 2015
Return-Path: <owner-svn-soc-all@freebsd.org>
Delivered-To: svn-soc-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 015CBA3D328
 for <svn-soc-all@mailman.ysv.freebsd.org>;
 Mon, 30 Nov 2015 22:15:00 +0000 (UTC) (envelope-from def@FreeBSD.org)
Received: from socsvn.freebsd.org (socsvn.freebsd.org
 [IPv6:2001:1900:2254:206a::50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E70A11A13
 for <svn-soc-all@FreeBSD.org>; Mon, 30 Nov 2015 22:14:59 +0000 (UTC)
 (envelope-from def@FreeBSD.org)
Received: from socsvn.freebsd.org ([127.0.1.124])
 by socsvn.freebsd.org (8.15.2/8.15.2) with ESMTP id tAUMExLl090993
 for <svn-soc-all@FreeBSD.org>; Mon, 30 Nov 2015 22:14:59 GMT
 (envelope-from def@FreeBSD.org)
Received: (from www@localhost)
 by socsvn.freebsd.org (8.15.2/8.15.2/Submit) id tAUMEx9n090991
 for svn-soc-all@FreeBSD.org; Mon, 30 Nov 2015 22:14:59 GMT
 (envelope-from def@FreeBSD.org)
Date: Mon, 30 Nov 2015 22:14:59 GMT
Message-Id: <201511302214.tAUMEx9n090991@socsvn.freebsd.org>
X-Authentication-Warning: socsvn.freebsd.org: www set sender to
 def@FreeBSD.org using -f
From: def@FreeBSD.org
To: svn-soc-all@FreeBSD.org
Subject: socsvn commit: r294627 - soc2013/def/crashdump-head/sbin/dumpon
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-soc-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the entire Summer of Code repository
 <svn-soc-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-soc-all>,
 <mailto:svn-soc-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-soc-all/>
List-Post: <mailto:svn-soc-all@freebsd.org>
List-Help: <mailto:svn-soc-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-soc-all>,
 <mailto:svn-soc-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Nov 2015 22:15:00 -0000

Author: def
Date: Mon Nov 30 22:14:58 2015
New Revision: 294627
URL: http://svnweb.FreeBSD.org/socsvn/?view=rev&rev=294627

Log:
  Zero DIOCSKERNELDUMP argument after use. Style.

Modified:
  soc2013/def/crashdump-head/sbin/dumpon/dumpon.c

Modified: soc2013/def/crashdump-head/sbin/dumpon/dumpon.c
==============================================================================
--- soc2013/def/crashdump-head/sbin/dumpon/dumpon.c	Mon Nov 30 22:06:47 2015	(r294626)
+++ soc2013/def/crashdump-head/sbin/dumpon/dumpon.c	Mon Nov 30 22:14:58 2015	(r294627)
@@ -215,9 +215,11 @@
 			err(EX_OSFILE, "%s", argv[0]);
 		check_size(fd, argv[0]);
 		bzero(&kda, sizeof(kda));
+
 		kda.kda_enable = 0;
 		i = ioctl(fd, DIOCSKERNELDUMP, &kda);
 		bzero(&kda, sizeof(kda));
+
 		if (pubkeyfile != NULL)
 			genkey(pubkeyfile, &kda);
 		kda.kda_enable = 1;
@@ -231,8 +233,10 @@
 		fd = open(_PATH_DEVNULL, O_RDONLY);
 		if (fd < 0)
 			err(EX_OSFILE, "%s", _PATH_DEVNULL);
+
 		kda.kda_enable = 0;
 		i = ioctl(fd, DIOCSKERNELDUMP, &kda);
+		bzero(&kda, sizeof(kda));
 		if (i == 0 && verbose)
 			printf("kernel dumps disabled\n");
 	}