From owner-freebsd-bugs@FreeBSD.ORG Mon Nov 7 05:50:12 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BA21D1065670 for ; Mon, 7 Nov 2011 05:50:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 7E78A8FC12 for ; Mon, 7 Nov 2011 05:50:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id pA75oCWQ048639 for ; Mon, 7 Nov 2011 05:50:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id pA75oCPb048638; Mon, 7 Nov 2011 05:50:12 GMT (envelope-from gnats) Resent-Date: Mon, 7 Nov 2011 05:50:12 GMT Resent-Message-Id: <201111070550.pA75oCPb048638@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ivan Klymenko Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D331E106564A for ; Mon, 7 Nov 2011 05:46:38 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id C34F38FC14 for ; Mon, 7 Nov 2011 05:46:38 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pA75kcZw093308 for ; Mon, 7 Nov 2011 05:46:38 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id pA75kcDd093307; Mon, 7 Nov 2011 05:46:38 GMT (envelope-from nobody) Message-Id: <201111070546.pA75kcDd093307@red.freebsd.org> Date: Mon, 7 Nov 2011 05:46:38 GMT From: Ivan Klymenko To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/162347: [patch] remove the extra variable in /sys/libkern/random.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2011 05:50:12 -0000 >Number: 162347 >Category: kern >Synopsis: [patch] remove the extra variable in /sys/libkern/random.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Nov 07 05:50:12 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Ivan Klymenko >Release: FreeBSD 10.0-CURRENT amd64 >Organization: individual >Environment: FreeBSD nonamehost 9.9-CURRENT FreeBSD 9.9-CURRENT #0 r227075M: Sat Nov 5 16:13:18 EET 2011 ivan@nonamehost:/usr/obj/usr/src/sys/mk9 amd64 >Description: remove the extra variable. variable "x" is not needed. >How-To-Repeat: >Fix: Patch attached with submission follows: --- ./sys/libkern/random.c.orig 2011-11-05 15:36:23.000000000 +0200 +++ ./sys/libkern/random.c 2011-11-05 15:40:18.000000000 +0200 @@ -57,19 +57,19 @@ u_long random() { - register long x, hi, lo, t; + register long hi, lo, t; /* - * Compute x[n + 1] = (7^5 * x[n]) mod (2^31 - 1). + * Compute randseed[n + 1] = (7^5 * randseed[n]) mod (2^31 - 1). * From "Random number generators: good ones are hard to find", * Park and Miller, Communications of the ACM, vol. 31, no. 10, * October 1988, p. 1195. */ /* Can't be initialized with 0, so use another value. */ - if ((x = randseed) == 0) - x = 123459876; - hi = x / 127773; - lo = x % 127773; + if (randseed == 0) + randseed = 123459876; + hi = randseed / 127773; + lo = randseed % 127773; t = 16807 * lo - 2836 * hi; if (t < 0) t += 0x7fffffff; >Release-Note: >Audit-Trail: >Unformatted: