From owner-freebsd-bluetooth@FreeBSD.ORG Tue Oct 19 11:30:38 2010 Return-Path: Delivered-To: freebsd-bluetooth@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5138E106566C for ; Tue, 19 Oct 2010 11:30:38 +0000 (UTC) (envelope-from plunky@rya-online.net) Received: from smtp6.freeserve.com (smtp6.freeserve.com [193.252.22.191]) by mx1.freebsd.org (Postfix) with ESMTP id 1058E8FC16 for ; Tue, 19 Oct 2010 11:30:37 +0000 (UTC) Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf3608.me.freeserve.com (SMTP Server) with ESMTP id 9375C7000091 for ; Tue, 19 Oct 2010 13:30:36 +0200 (CEST) Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf3608.me.freeserve.com (SMTP Server) with ESMTP id 8742D7000092 for ; Tue, 19 Oct 2010 13:30:36 +0200 (CEST) Received: from rya-online.net (unknown [89.194.103.211]) by mwinf3608.me.freeserve.com (SMTP Server) with SMTP id A549B7000091 for ; Tue, 19 Oct 2010 13:30:35 +0200 (CEST) X-ME-UUID: 20101019113035677.A549B7000091@mwinf3608.me.freeserve.com Received: (nullmailer pid 1186 invoked by uid 1000); Tue, 19 Oct 2010 11:30:50 -0000 Date: Tue, 19 Oct 2010 12:30:50 +0100 (BST) To: freebsd-bluetooth@freebsd.org User-Agent: Alpine 2.00 (NEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-316003808-1287487850=:1648" Message-Id: <1287487850.821410.993.nullmailer@galant.ukfsn.org> From: Iain Hibbert Subject: obexapp spinner arithmetic error X-BeenThere: freebsd-bluetooth@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Using Bluetooth in FreeBSD environments List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2010 11:30:38 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-316003808-1287487850=:1648 Content-Type: TEXT/PLAIN; charset=US-ASCII Hi, I notice sometimes that obexapp backsteps to the end of the previous line after it has finished, because of an extraneous backspace.. I traced this to an arithmetic error in obexapp_event_progress() function, as spinner[] array has 5 characters plus a terminating NUL character, so sizeof = 6. patch attached to fix this regards, iain --0-316003808-1287487850=:1648 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=spinner.diff Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=spinner.diff LS0tIGV2ZW50LmMub3JpZwkyMDA5LTA4LTIwIDIyOjU3OjE4LjAwMDAwMDAw MCArMDEwMA0KKysrIGV2ZW50LmMJMjAxMC0xMC0xOSAxMjoyNTo1NS4wMDAw MDAwMDAgKzAxMDANCkBAIC0xMzcsNyArMTM3LDcgQEAgb2JleGFwcF9ldmVu dF9wcm9ncmVzcyhvYmV4X3QgKmhhbmRsZSwgXw0KIAkJc3RhdGljIHVpbnQz Ml90CXNwaW5uZXJfaWR4ID0gMDsNCiANCiAJCXByaW50ZigiJWNcYiIsIHNw aW5uZXJbc3Bpbm5lcl9pZHggKytdKTsNCi0JCWlmIChzcGlubmVyX2lkeCA+ PSBzaXplb2Yoc3Bpbm5lcikvc2l6ZW9mKHNwaW5uZXJbMF0pKQ0KKwkJaWYg KHNwaW5uZXJfaWR4ID09IChzaXplb2Yoc3Bpbm5lcikvc2l6ZW9mKHNwaW5u ZXJbMF0pIC0gMSkpDQogCQkJc3Bpbm5lcl9pZHggPSAwOw0KIAl9DQogfSAv KiBvYmV4YXBwX2V2ZW50X3Byb2dyZXNzICovDQo= --0-316003808-1287487850=:1648--