From owner-svn-src-all@FreeBSD.ORG Tue Mar 10 18:00:33 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0C41DB3A; Tue, 10 Mar 2015 18:00:33 +0000 (UTC) Received: from relay.mailchannels.net (ftx-008-i768.relay.mailchannels.net [50.61.143.68]) by mx1.freebsd.org (Postfix) with ESMTP id EBA526BF; Tue, 10 Mar 2015 18:00:30 +0000 (UTC) X-Sender-Id: duocircle|x-authuser|hippie Received: from smtp1.ore.mailhop.org (ip-10-213-14-133.us-west-2.compute.internal [10.213.14.133]) by relay.mailchannels.net (Postfix) with ESMTPA id 54AB8120544; Tue, 10 Mar 2015 13:27:06 +0000 (UTC) X-Sender-Id: duocircle|x-authuser|hippie Received: from smtp1.ore.mailhop.org (smtp1.ore.mailhop.org [10.21.145.197]) (using TLSv1 with cipher DHE-RSA-AES256-SHA) by 0.0.0.0:2500 (trex/5.4.8); Tue, 10 Mar 2015 13:27:08 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: duocircle|x-authuser|hippie X-MailChannels-Auth-Id: duocircle X-MC-Loop-Signature: 1425994027448:1231751392 X-MC-Ingress-Time: 1425994027448 Received: from c-73-34-117-227.hsd1.co.comcast.net ([73.34.117.227] helo=ilsoft.org) by smtp1.ore.mailhop.org with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.82) (envelope-from ) id 1YVKBd-0005um-6u; Tue, 10 Mar 2015 13:27:05 +0000 Received: from revolution.hippie.lan (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t2ADR31s009527; Tue, 10 Mar 2015 07:27:03 -0600 (MDT) (envelope-from ian@freebsd.org) X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 73.34.117.227 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX192pTePSl9xBlk/DW+T3T4M Message-ID: <1425994023.33324.9.camel@freebsd.org> Subject: Re: svn commit: r279828 - head/sys/dev/cadence From: Ian Lepore To: Gleb Smirnoff Date: Tue, 10 Mar 2015 07:27:03 -0600 In-Reply-To: <20150310102525.GU17947@FreeBSD.org> References: <201503092239.t29MdxUo089384@svn.freebsd.org> <20150310102525.GU17947@FreeBSD.org> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-AuthUser: hippie Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Thomas Skibo X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Mar 2015 18:00:33 -0000 On Tue, 2015-03-10 at 13:25 +0300, Gleb Smirnoff wrote: > On Mon, Mar 09, 2015 at 10:39:59PM +0000, Ian Lepore wrote: > I> Author: ian > I> Date: Mon Mar 9 22:39:58 2015 > I> New Revision: 279828 > I> URL: https://svnweb.freebsd.org/changeset/base/279828 > I> > I> Log: > I> Use the new ifnet API. Also, allocate bus_dma_maps as needed instead of > I> pre-allocating them all at start-up. Also fix a bug in cgem_stop(); before, > I> it wasn't properly unloading dma maps due to a cut-and-paste error. > > Ian, the new ifnet API isn't the last word in ifnet API. :) > > Since you are already into that, I'd appreciate if you look > into projects/ifnet branch and convert cgem(4) to it. > > As examples, you can look at msk(4), bge(4), xl(4) and vtnet(4) > in the branch. > Hrm, I know nothing about the cgem driver and very little about ethernet drivers in general (despite having "written" one, mostly by cut and paste from working drivers). I was committing this on behalf of a non-committer contributor who maintains the Xilinx/Zynq arm code. I just noticed I forgot to add to the commit... Submitted by: Thomas Skibo I'll add him to the CC on this, in case he has time to work up a patchset for the projects/ifnet branch for you. -- Ian