From owner-freebsd-hackers@FreeBSD.ORG Mon Nov 22 12:32:12 2010 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6DB711065670; Mon, 22 Nov 2010 12:32:12 +0000 (UTC) (envelope-from onemda@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id D0CB48FC0A; Mon, 22 Nov 2010 12:32:11 +0000 (UTC) Received: by wwd20 with SMTP id 20so7029838wwd.31 for ; Mon, 22 Nov 2010 04:32:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=eBzFnUfFn00L0dkyHk8+j0tEbEumWd0JMPxvWg4s60U=; b=MIkyU2xgxs0Hp5aPV8I3NLT+cTUhmqoB7vYeJCGSK8sEjDRUrXmLBXQoZxXBFPPkHI F5wS4ABRkh4KFj1uuZ+5ImPr+gtCicmPTjhfmobufOzdoN0AzhUMFbZIgPELzpwI/M8E kfJg8OytddSYDOM1+Gt5zX/v7hfkjnsCmtAg8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=rPG+YHiwc0BY65A+YL+Uq0Q7h3maJl5VtuFpqeP/epRVpACqdCqryr1F02eqQBcQC2 lLr1aLdGUIF82Rf/7r4KlTBQOUgia0gnvdw/vu0o9qZuMZ5fQgVRGSc9nxWuU+BZ4Qqh +2GuqVLPid06a120pBrSYsWf69PwbCEJ6rosg= MIME-Version: 1.0 Received: by 10.216.155.68 with SMTP id i46mr4705511wek.92.1290429126674; Mon, 22 Nov 2010 04:32:06 -0800 (PST) Received: by 10.216.234.82 with HTTP; Mon, 22 Nov 2010 04:32:06 -0800 (PST) In-Reply-To: <4CEA328C.2060508@freebsd.org> References: <4CE98C7E.90301@freebsd.org> <4CEA328C.2060508@freebsd.org> Date: Mon, 22 Nov 2010 12:32:06 +0000 Message-ID: From: Paul B Mahol To: Andriy Gapon Content-Type: text/plain; charset=ISO-8859-1 Cc: hackers@freebsd.org Subject: Re: Remove printf in acpi_tz_sanity() X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Nov 2010 12:32:12 -0000 On 11/22/10, Andriy Gapon wrote: > on 22/11/2010 01:18 Paul B Mahol said the following: >> On Sun, Nov 21, 2010 at 9:17 PM, Andriy Gapon wrote: >>> As is - this is a perfect candidate for a "local only" patch. >>> To be included into the tree - this, most probably, has to be controlled >>> by a >>> tunable/sysctl. >> >> So solution for useless console spamming is to add useless sysctl. > > Are you absolutely sure that they both are/would be useless? > For all uses of acpi_tz_sanity()? > E.g. if some system has never produced those messages in years and then > suddenly > starts spewing them out, would that be useless information? Linux, OpenBSD are missing this killer feature. > >> For -1 values, sane default values should be picked up. > > For current temperature too? > >> Anyway only _CRT is showing on console, and _PSV & _HOT are both -1 for >> tz0. > > On your system. > >> I'm not first one mentioning this and issue is old several years. > > OK. Sorry.