From owner-freebsd-audit Wed Mar 27 3:30:28 2002 Delivered-To: freebsd-audit@freebsd.org Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.139.170]) by hub.freebsd.org (Postfix) with ESMTP id AB6C937B400 for ; Wed, 27 Mar 2002 03:30:23 -0800 (PST) Received: (from uucp@localhost) by storm.FreeBSD.org.uk (8.11.6/8.11.6) with UUCP id g2RBUBs82346; Wed, 27 Mar 2002 11:30:11 GMT (envelope-from mark@grimreaper.grondar.za) Received: from grimreaper (localhost [127.0.0.1]) by grimreaper.grondar.org (8.12.2/8.12.2) with ESMTP id g2RBTnQE007451; Wed, 27 Mar 2002 11:29:49 GMT (envelope-from mark@grimreaper.grondar.za) Message-Id: <200203271129.g2RBTnQE007451@grimreaper.grondar.org> To: Bruce Evans Cc: audit@FreeBSD.ORG Subject: Re: Library __progname cleanups - commit candidate References: <20020327214800.B3808-100000@gamplex.bde.org> In-Reply-To: <20020327214800.B3808-100000@gamplex.bde.org> ; from Bruce Evans "Wed, 27 Mar 2002 21:55:11 +1100." Date: Wed, 27 Mar 2002 11:29:49 +0000 From: Mark Murray Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > > > too carefully there, so they don't already cover ). > > > > You don't think this "standard way" could be documented somewhere, do you? > > The logs for the commits that added it should be sufficient. There are > hundreds of examples. "Should be" != "Is". Grovelling out the right example is an exercise in futility, as for each example there is usually a counterexample. > > > > - snprintf(str, sizeof(str), "%s - Warning: Thread %p attempted to lock %p from %s (%d) was left locked from %s (%d)\n", __progname, curthread, lck, fname, lineno, lck->fname, lck->lineno); > > > > + snprintf(str, sizeof(str), "%s - Warning: Thread %p attempted to lock %p from %s (%d) was left locked from %s (%d)\n", _getprogname(), curthread, lck, fname, lineno, lck->fname, lck->lineno); > > > > > > Disgustingly long line longer than before. > > > > I'd prefer to solve this with an appropriate indent(1). > > FreeBSD's indent(1) doesn't understand long lines at all. FSF/GNU indent is much better, and large parts of it are still BSD licensed. I'm working on backporting those bits. M -- o Mark Murray \_ O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message