From owner-svn-src-head@freebsd.org Tue Nov 17 19:06:52 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 40E0CA31ABC; Tue, 17 Nov 2015 19:06:52 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A941E175D; Tue, 17 Nov 2015 19:06:51 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id tAHJ6jQh090781 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Tue, 17 Nov 2015 21:06:46 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua tAHJ6jQh090781 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id tAHJ6jNf090780; Tue, 17 Nov 2015 21:06:45 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 17 Nov 2015 21:06:45 +0200 From: Konstantin Belousov To: Bryan Drewery Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290812 - head Message-ID: <20151117190645.GH58629@kib.kiev.ua> References: <201511140145.tAE1jbDx010538@repo.freebsd.org> <20151117085510.GB58629@kib.kiev.ua> <564B7988.1090506@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <564B7988.1090506@FreeBSD.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Nov 2015 19:06:52 -0000 On Tue, Nov 17, 2015 at 11:01:28AM -0800, Bryan Drewery wrote: > On 11/17/15 12:55 AM, Konstantin Belousov wrote: > > On Sat, Nov 14, 2015 at 01:45:37AM +0000, Bryan Drewery wrote: > >> Author: bdrewery > >> Date: Sat Nov 14 01:45:37 2015 > >> New Revision: 290812 > >> URL: https://svnweb.freebsd.org/changeset/base/290812 > >> > >> Log: > >> Avoid setting schg in the objtree for lib32 build. > >> > >> Reported by: kib > >> Sponsored by: EMC / Isilon Storage Division > >> MFC after: 1 week > >> > >> Modified: > >> head/Makefile.inc1 > >> > >> Modified: head/Makefile.inc1 > >> ============================================================================== > >> --- head/Makefile.inc1 Sat Nov 14 01:40:12 2015 (r290811) > >> +++ head/Makefile.inc1 Sat Nov 14 01:45:37 2015 (r290812) > >> @@ -716,10 +716,10 @@ build32: .PHONY > >> build-tools > >> .endfor > >> ${_+_}cd ${.CURDIR}; \ > >> - ${LIB32WMAKE} -f Makefile.inc1 libraries > >> + ${LIB32WMAKE} -f Makefile.inc1 -DNO_FSCHG libraries > >> .for _t in obj depend all > >> ${_+_}cd ${.CURDIR}/libexec/rtld-elf; PROG=ld-elf32.so.1 ${LIB32WMAKE} \ > >> - DIRPRFX=libexec/rtld-elf/ ${_t} > >> + -DNO_FSCHG DIRPRFX=libexec/rtld-elf/ ${_t} > >> ${_+_}cd ${.CURDIR}/usr.bin/ldd; PROG=ldd32 ${LIB32WMAKE} \ > >> DIRPRFX=usr.bin/ldd ${_t} > >> .endfor > > Thank you. > > > > I remember, the previous attempts to fix this broke setting the noschg flag > > on the compat32 install. This one seems to be correct, am I right ? > > > > Yes, the actual install is still safely setting schg. > > I am curious about your make.conf and src.conf though as I was unable to > reproduce the problem, but see evidence that this would fix it. I have INSTALL?= install INSTALL+=-CS in make.conf. src.conf is WITHOUT_PROFILE=yes but this should be not relevant.