From owner-svn-src-stable-11@freebsd.org Sat Dec 15 09:26:28 2018 Return-Path: Delivered-To: svn-src-stable-11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 56E93133E22F; Sat, 15 Dec 2018 09:26:28 +0000 (UTC) (envelope-from Andre.Albsmeier@siemens.com) Received: from goliath.siemens.de (goliath.siemens.de [192.35.17.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "goliath.siemens.de", Issuer "Siemens Issuing CA Internet Server 2017" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E72C98E695; Sat, 15 Dec 2018 09:26:26 +0000 (UTC) (envelope-from Andre.Albsmeier@siemens.com) Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id wBF99QKY000737 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 15 Dec 2018 10:09:27 +0100 Received: from curry.mchp.siemens.de (curry.mchp.siemens.de [139.25.40.130]) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id wBF99Qke027696; Sat, 15 Dec 2018 10:09:26 +0100 Received: (from user@localhost) by curry.mchp.siemens.de (8.15.2/8.15.2) id wBF99QJg071688; Date: Sat, 15 Dec 2018 10:09:26 +0100 From: Andre Albsmeier To: Eugene Grosbein Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r341794 - stable/11/etc/periodic/weekly Message-ID: <20181215090926.GA33682@bali> References: <201812101424.wBAEOgbC053582@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201812101424.wBAEOgbC053582@repo.freebsd.org> User-Agent: Mutt/1.7.2 (2016-11-26) X-Rspamd-Queue-Id: E72C98E695 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of Andre.Albsmeier@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=Andre.Albsmeier@siemens.com X-Spamd-Result: default: False [-1.29 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.90)[-0.895,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+exists:192.35.17.28.spf.siemens.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[siemens.com]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_HAM_LONG(-0.91)[-0.914,0]; RCVD_COUNT_THREE(0.00)[4]; RCVD_TLS_LAST(0.00)[]; NEURAL_SPAM_SHORT(0.84)[0.836,0]; MX_GOOD(-0.01)[meleagros.siemens.com,hylas.siemens.com,paxos.siemens.com,gordi.siemens.com,zetes.siemens.com,hephaistos.siemens.com,balduin.siemens.com]; IP_SCORE(-0.00)[country: DE(-0.01)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; ASN(0.00)[asn:15465, ipnet:192.35.16.0/22, country:DE]; RCVD_IN_DNSWL_HI(-0.50)[28.17.35.192.list.dnswl.org : 127.0.13.3] X-BeenThere: svn-src-stable-11@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for only the 11-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Dec 2018 09:26:28 -0000 On Mon, 10-Dec-2018 at 14:24:42 +0000, Eugene Grosbein wrote: > Author: eugen > Date: Mon Dec 10 14:24:41 2018 > New Revision: 341794 > URL: https://svnweb.freebsd.org/changeset/base/341794 > > Log: > MFC r340322-r340324,r340327: periodic/etc/weekly/340.noid > > Prevent periodic/etc/weekly/340.noid from descending into root directories > of jails. Jails have their own user/group databases and this script > can produce multiple false warnings, not to mention significant extra > load in case of large jailed subtrees. Leave this check for jailed > invocations of the same script. This gave me: Check for files with an unknown user or group: .: cannot open /usr/share/bsdconfig/common.subr: No such file or directory on systems where bsdconfig is not installed. -Andre > > Modified: > stable/11/etc/periodic/weekly/340.noid > Directory Properties: > stable/11/ (props changed) > > Modified: stable/11/etc/periodic/weekly/340.noid > ============================================================================== > --- stable/11/etc/periodic/weekly/340.noid Mon Dec 10 14:19:57 2018 (r341793) > +++ stable/11/etc/periodic/weekly/340.noid Mon Dec 10 14:24:41 2018 (r341794) > @@ -16,8 +16,26 @@ case "$weekly_noid_enable" in > echo "" > echo "Check for files with an unknown user or group:" > > + # Host should not test jailed subtrees as jails have their own > + # databases of users and groups. Leave them for jailed invocations > + # of this script. > + > + exclude='' > + if [ $(sysctl -n security.jail.jailed) = 0 ]; then > + sep=: > + OIFS="$IFS" > + IFS="$sep" > + for param in $(jail -f "`sysrc -n jail_conf`" -e "$sep" 2>/dev/null) > + do > + case "$param" in > + path=*) exclude="$exclude -path ${param#path=} -prune -or" > + esac > + done > + IFS="$OIFS" > + fi > + > rc=$(find -H ${weekly_noid_dirs:-/} \ > - \( ! -fstype local -prune -or -name \* \) -and \ > + \( $exclude ! -fstype local -prune -or -name \* \) -and \ > \( -nogroup -o -nouser \) -print | sed 's/^/ /' | > tee /dev/stderr | wc -l) > [ $rc -gt 1 ] && rc=1 > _______________________________________________ > svn-src-stable-11@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-stable-11 > To unsubscribe, send any mail to "svn-src-stable-11-unsubscribe@freebsd.org" -- "FreeBSD has always been the operating system that GNU/Linux-based operating systems should have been." - Frank Pohlmann, IBM