From owner-cvs-src@FreeBSD.ORG Fri Nov 3 21:36:08 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3453C16A528; Fri, 3 Nov 2006 21:36:08 +0000 (UTC) (envelope-from rrs@cisco.com) Received: from sj-iport-5.cisco.com (sj-iport-5.cisco.com [171.68.10.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id 039F343E1F; Fri, 3 Nov 2006 21:35:04 +0000 (GMT) (envelope-from rrs@cisco.com) Received: from sj-dkim-2.cisco.com ([171.71.179.186]) by sj-iport-5.cisco.com with ESMTP; 03 Nov 2006 13:35:00 -0800 X-IronPort-AV: i="4.09,386,1157353200"; d="scan'208"; a="339278530:sNHT55875550" Received: from sj-core-5.cisco.com (sj-core-5.cisco.com [171.71.177.238]) by sj-dkim-2.cisco.com (8.12.11.20060308/8.12.11) with ESMTP id kA3LZ0Ws022028; Fri, 3 Nov 2006 13:35:00 -0800 Received: from xbh-sjc-231.amer.cisco.com (xbh-sjc-231.cisco.com [128.107.191.100]) by sj-core-5.cisco.com (8.12.10/8.12.6) with ESMTP id kA3LZ0W4011509; Fri, 3 Nov 2006 13:35:00 -0800 (PST) Received: from xfe-sjc-212.amer.cisco.com ([171.70.151.187]) by xbh-sjc-231.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.211); Fri, 3 Nov 2006 13:35:00 -0800 Received: from [127.0.0.1] ([171.68.225.134]) by xfe-sjc-212.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.1830); Fri, 3 Nov 2006 13:34:59 -0800 Message-ID: <454BB5DC.4030903@cisco.com> Date: Fri, 03 Nov 2006 16:34:20 -0500 From: Randall Stewart User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Doug Barton References: <200611031948.kA3JmuZ6072620@repoman.freebsd.org> <454BAEF0.6050807@FreeBSD.org> <454BB06E.40202@cisco.com> In-Reply-To: <454BB06E.40202@cisco.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 03 Nov 2006 21:34:59.0756 (UTC) FILETIME=[E9FA9EC0:01C6FF8F] DKIM-Signature: a=rsa-sha1; q=dns; l=2830; t=1162589700; x=1163453700; c=relaxed/simple; s=sjdkim2002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=rrs@cisco.com; z=From:Randall=20Stewart=20 |Subject:Re=3A=20cvs=20commit=3A=20src/sys/netinet=20sctp_asconf.c; X=v=3Dcisco.com=3B=20h=3Ds3++GMTXezzrfs5qHwjv2yBGZ40=3D; b=wPRHwja1xzy5YtPoXRePdQxmi/IsHRRri8v6JkHGVhvq7yjSl1zRdZlvUsQ6BTrNZyQcb4HS mA+wfOef3Xs5cJLRqs7RiBfL4eHsfpAJy5s9n2E75RLeY0CXGmJ0jd4Z; Authentication-Results: sj-dkim-2.cisco.com; header.From=rrs@cisco.com; dkim=pass ( sig from cisco.com verified; ); Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet sctp_asconf.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2006 21:36:08 -0000 Randall Stewart wrote: >> > Well... I doubt it... unless tinderbox started building with > options SCTP > shortly after I commited the SCTP code in this morning... > > I am not seeing a build problem in x86 land.. I just got a complete > cvsup now.. and made sure this all builds.. (with option SCTP)... > Ok I just went and looked at these.. I fixed easily: /src/sys/netinet/sctp_usrreq.c: In function `sctp_disconnect': /src/sys/netinet/sctp_usrreq.c:1138: warning: cast from pointer to integer of different size /src/sys/netinet/sctp_usrreq.c: In function `sctp_shutdown': /src/sys/netinet/sctp_usrreq.c:1279: warning: cast from pointer to integer of different size The above two are just a silly printf.. and casting a pointer to a (u_int)... ok.. no need for the pointer print anyway.. so I can remove it easily... /src/sys/netinet/sctp_usrreq.c: In function `sctp_optsset': /src/sys/netinet/sctp_usrreq.c:3136: warning: cast from pointer to integer of different size The above one I will have to ask if any one of you can give me a hand.. I am not a sparcy person ;-) and the line is: on_off = (mtod(m, int)); (on_off is declared as a int on_off; a few lines above it). So what is wrong with mtod() to an int and setting that int into an int variable... I knew sparc's were big into 64 bit things .. but an int to an int is a problem???? Now the other set of errors on amd (yet another platform I don't have ahh if only I could buy more toys :-0): /src/sys/compat/freebsd32/freebsd32_proto.h:396: warning: redundant redeclaration of 'sctp_peeloff' /src/sys/sys/sysproto.h:1813: warning: previous declaration of 'sctp_peeloff' was here /src/sys/compat/freebsd32/freebsd32_proto.h:397: warning: redundant redeclaration of 'sctp_generic_sendmsg' /src/sys/sys/sysproto.h:1814: warning: previous declaration of 'sctp_generic_sendmsg' was here /src/sys/compat/freebsd32/freebsd32_proto.h:398: warning: redundant redeclaration of 'sctp_generic_sendmsg_iov' /src/sys/sys/sysproto.h:1815: warning: previous declaration of 'sctp_generic_sendmsg_iov' was here /src/sys/compat/freebsd32/freebsd32_proto.h:399: warning: redundant redeclaration of 'sctp_generic_recvmsg' /src/sys/sys/sysproto.h:1816: warning: previous declaration of 'sctp_generic_recvmsg' was here *** Error code 1 Since I don't understand the compat stuff... and for that matter this is the first time I have ever copied them in there (for the commit as it said to do in kern/syscalls.master)... Is there some thing special I am supposed to do when I put these critters in here? Are they supposed to be renamed differntly in some way?? I am clueless on this one :-0 R -- Randall Stewart NSSTG - Cisco Systems Inc. 803-345-0369 803-317-4952 (cell)