From owner-cvs-src@FreeBSD.ORG Wed Nov 28 07:54:43 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 738F916A417; Wed, 28 Nov 2007 07:54:43 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 4CBF913C45D; Wed, 28 Nov 2007 07:54:43 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id lAS7shNT057939; Wed, 28 Nov 2007 07:54:43 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id lAS7shrQ057938; Wed, 28 Nov 2007 07:54:43 GMT (envelope-from yar) Message-Id: <200711280754.lAS7shrQ057938@repoman.freebsd.org> From: Yar Tikhiy Date: Wed, 28 Nov 2007 07:54:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/newfs newfs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2007 07:54:43 -0000 yar 2007-11-28 07:54:43 UTC FreeBSD src repository Modified files: sbin/newfs newfs.c Log: - Pay attention to the fact that ioctl(2) is only known to return -1 on error while any other return value from it can indicate success. (See RETURN VALUE in our ioctl(2) manpage and the POSIX spec.) - Avoid assumptions about the state of the data buffer after ioctl(2) failure. Revision Changes Path 1.84 +5 -4 src/sbin/newfs/newfs.c