From owner-cvs-all Tue Jul 4 4:25:24 2000 Delivered-To: cvs-all@freebsd.org Received: from mass.osd.bsdi.com (adsl-63-202-177-51.dsl.snfc21.pacbell.net [63.202.177.51]) by hub.freebsd.org (Postfix) with ESMTP id 1AB0337B78E; Tue, 4 Jul 2000 04:25:18 -0700 (PDT) (envelope-from msmith@mass.osd.bsdi.com) Received: from mass.osd.bsdi.com (localhost [127.0.0.1]) by mass.osd.bsdi.com (8.9.3/8.9.3) with ESMTP id EAA02524; Tue, 4 Jul 2000 04:30:32 -0700 (PDT) (envelope-from msmith@mass.osd.bsdi.com) Message-Id: <200007041130.EAA02524@mass.osd.bsdi.com> X-Mailer: exmh version 2.1.1 10/15/1999 To: Poul-Henning Kamp Cc: Nick Hibma , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys bus.h bus_private.h src/sys/kern subr_bus.c In-reply-to: Your message of "Mon, 03 Jul 2000 15:44:36 +0200." <6139.962631876@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 04 Jul 2000 04:30:32 -0700 From: Mike Smith Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > In message , Nick Hibma wri > tes: > > >I object to it. > > Then don't use it. It has legitimate uses. > > In fact: I object to newbus allocating the softc for exactly the > reason this one is needed: There may be a 1:N or N:1 correspondence > between softc's and newbus devices. In this case I have two > newbus devices for one softc. (Well, actually I have two newbus > devices for five softc's, but lets not get into that) > > >Apart from that, where is the manpage for it? > > On my TODO list. > > >Please make > >sure you mention that this method should only be called in rare cases > >where the softc allocated by the newbus system would not do for some > >obscure reason. > > I disagree, as you can see above. Actually, I'm still not happy with what you're claiming to be the solution for your problem. There are better ways to go about doing what you're trying to do, and none of them require the sort of bodge you've indulged in here. Firstly - I don't buy that you can't uniquely identify the device up front. This would be a violation of the PCI spec, just for starters. Secondly - you can install placeholders with null/placeholder softcs while you're collecting the resources for the ultimate device. If you're really ambitious, you can even unwind these if the probe set fails and cause a reprobe of the bus (once you've noted for yourself not to take the device again). -- ... every activity meets with opposition, everyone who acts has his rivals and unfortunately opponents also. But not because people want to be opponents, rather because the taks and relationships force people to take different points of view. [Dr. Fritz Todt] To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message