From owner-freebsd-testing@FreeBSD.ORG Fri Apr 4 19:26:09 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4AE0A641; Fri, 4 Apr 2014 19:26:09 +0000 (UTC) Received: from mail-ve0-x22f.google.com (mail-ve0-x22f.google.com [IPv6:2607:f8b0:400c:c01::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D8188806; Fri, 4 Apr 2014 19:26:08 +0000 (UTC) Received: by mail-ve0-f175.google.com with SMTP id oz11so1794531veb.20 for ; Fri, 04 Apr 2014 12:26:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=TAE+YUtvaToNR34c96HeTxvHzi+Zv7RZtjlK5DXOBcU=; b=SKiti+jjNmxXPY/NceMQsOqDUK/v3sEDDu7ue4NsZETWx/YNRsSQAEcPYsipZ7QUnr Y+ehSo4wb34di0LwmU9VaumxRZ0e+ZDPy5rTKOYwj/1w98FdWwdHVxJs1B+Z5FA/8gb7 CbOxwvcax3O7cqiTRpxV23k5PJLb2WX9EqOUbVbog84CYdKvNZ6fUbRRAF7DvaFSfcay c8J5sOI8GBKsFr2SIbHvNHFDLubId1RKEXeg/NCem0Q65L6xMF5n+1M+JPp4u2AS+WPY 9Mhr0bZqQYJ9ZjSxKjkvM5gqCK1GY6tSJ4rgMCCIjoOUTjnnyw2nGXkwuskG9HQSIwAI /v/w== MIME-Version: 1.0 X-Received: by 10.52.6.162 with SMTP id c2mr12234142vda.6.1396639567931; Fri, 04 Apr 2014 12:26:07 -0700 (PDT) Received: by 10.221.67.136 with HTTP; Fri, 4 Apr 2014 12:26:07 -0700 (PDT) In-Reply-To: References: <20140402085349.GA61802@x2.osted.lan> <20140404190543.GA652@mastodon.meroh.net> Date: Fri, 4 Apr 2014 12:26:07 -0700 Message-ID: Subject: Re: ATF work From: Garrett Cooper To: Alan Somers Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-testing@freebsd.org" , Peter Holm X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Apr 2014 19:26:09 -0000 On Fri, Apr 4, 2014 at 12:19 PM, Alan Somers wrote: > On Fri, Apr 4, 2014 at 1:05 PM, Julio Merino wrote: >> Just a couple of minor comments: >> >> On Wed, Apr 02, 2014 at 11:07:04AM -0700, Garrett Cooper wrote: >>> (Just to fill in some context on some of the items here) >>> >>> On Wed, Apr 2, 2014 at 9:31 AM, Alan Somers wrote: >>> > lib/libc/tests/net/Makefile has one tested comment out with the >>> > comment "test uses rump". Would it be possible instead to leave the >>> > test in the build, but put "require.progs rump_server" in the relevant >>> > test cases' heads? >>> >>> Probably carryover from NetBSD that should be pushed back to NetBSD. >> >> Why? rump is "standard" in NetBSD so that's probably not going to fly. >> It'd be like saying "require.progs = ls". > > I don't know about NetBSD, but FreeBSD has a lot of optional stuff in > base that's compiled in by default. For example, the entire Bluetooth > stack can be disabled by WITHOUT_BLUETOOTH=yes make buildworld. At > $WORK, I disabled a whole bunch of stuff that way to slim down our > product's image. A deeply embedded system, I'm sure, would disable > even more. If rump can be disabled in a NetBSD build, then it would > be worthwhile for rump-based ATF tests to identify themselves via > require.progs. Rump is optional, so I think that Alan's point is valid (from http://netbsd.gw.com/cgi-bin/man-cgi?mk.conf++NetBSD-current): MKRUMP Can be set to ``yes'' or ``no''. Indicates whether the rump(3) headers, libraries and programs are to be installed. Default: ``yes'' I'll add that to my fork. Thanks! -Garrett