From owner-svn-src-all@freebsd.org Wed Aug 29 14:02:34 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 827A7108AFFD; Wed, 29 Aug 2018 14:02:34 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 047F88E229; Wed, 29 Aug 2018 14:02:34 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pf1-x435.google.com with SMTP id s13-v6so2318018pfi.7; Wed, 29 Aug 2018 07:02:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gykFQft97ZUIKvWqOEEeFLjJHNjClfnZuN7Yp8/diA0=; b=QZU1Jw2NwbFJ3GiugU21D+zbhxRA7P/5dTh/rn7dCykgq5tlYdoGcld0Woc4Ydv0tq sGMnuOY2MWMUU8WcNWsu7us8IqrjWLGKx1iTEyVwmuDTdZaquuuPQunjIA0jt4GgqyxC EMJ/6Xk5l8C933pwhvlmT1HqusCyOzoCBxvQQ1QjBPvOyktdIHJraVFlClFQEXn9HRGk bfB3qai5egM3QhM0mXBVYP1Nn+p7UmrPWNzNgZM38CpKlssYoiv/lqVnaFFsJ4aWn6at VBFyjycrAP3yd8trAxfBq55Hw+e78mNXw20IDL/unnLMjBOoPIAacHGBATW7SisdciOn e3Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=gykFQft97ZUIKvWqOEEeFLjJHNjClfnZuN7Yp8/diA0=; b=LeaRi7VqmdUQX3y9usOYE2bqS7PtkFdy7XZvm6s3PF2PAX47qStw/FpbHA41CoB7aA GmpIQisMPlfO60canI92dhM9kL2tfRBT7+yGYFPslUwpaLQ0hr/rV43GcNX+O+yhb8Jo wMeBh/1kdp2RPejR4YN3YwHcBn/9l1CuMMZzKMFvkAqfKr/ccKbzCJvFWILGd+b8pYb1 sr5k4LETYlMxF09ijk69Ga5sCbCPDKfe8s3ansxbDU43uqfX0dVLT2OsZxu1omLOOYgj ZsVp2iSHBQKq72D+MGjsGILxeXNixbkpSO2uWbkq0d4O9R4GlrtuWVBU+pClwLx097rX FgSg== X-Gm-Message-State: APzg51CWTT03Fg0dm4TjciHompDTaXr6GmFWbpza2g2sezFAVHZL3CoL Sjdb6IGoXciH7iZUZ8i6vq+JqDmf+t8= X-Google-Smtp-Source: ANB0Vdb1z8rE+F+1B2nmYYZml0EsWessQCZFrpFcHmtB0y+GV3sf+nm2gMFSOyYHwcM+/lk9e7nQBQ== X-Received: by 2002:a63:b914:: with SMTP id z20-v6mr5900760pge.396.1535551352697; Wed, 29 Aug 2018 07:02:32 -0700 (PDT) Received: from raichu (toroon0560w-lp130-09-70-52-224-239.dsl.bell.ca. [70.52.224.239]) by smtp.gmail.com with ESMTPSA id y124-v6sm7866941pfg.63.2018.08.29.07.02.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Aug 2018 07:02:31 -0700 (PDT) Sender: Mark Johnston Date: Wed, 29 Aug 2018 10:02:28 -0400 From: Mark Johnston To: Kristof Provost Cc: Matt Macy , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334647 - in head: lib/libpmc sys/dev/hwpmc sys/kern sys/sys usr.sbin usr.sbin/pmc Message-ID: <20180829140228.GE5641@raichu> References: <201806050426.w554QfVq001396@repo.freebsd.org> <7049241C-BA3D-4652-9568-C4387557F8E3@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7049241C-BA3D-4652-9568-C4387557F8E3@FreeBSD.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2018 14:02:34 -0000 On Wed, Aug 29, 2018 at 02:41:49PM +0200, Kristof Provost wrote: > On 5 Jun 2018, at 6:26, Matt Macy wrote: > > Author: mmacy > > Date: Tue Jun 5 04:26:40 2018 > > New Revision: 334647 > > URL: https://svnweb.freebsd.org/changeset/base/334647 > > > > Log: > > hwpmc: log name->pid, name->tid mappings > > > > By logging all threads and processes 'pmc filter' > > can now filter on process or thread name, relieving > > the user of the burden of determining which tid or > > pid was which when the sample was taken. > > > > % pmc filter -T if_io_tqg -P nginx pmc.log pmc-iflib.log > > > > % pmc filter -x -T idle pmc.log pmc-noidle.log > > > > Added: > > head/usr.sbin/pmc/cmd_pmc_filter.cc > > - copied, changed from r334645, > > head/usr.sbin/pmc/cmd_pmc_filter.c > > Deleted: > > head/usr.sbin/pmc/cmd_pmc_filter.c > > Modified: > > head/lib/libpmc/pmclog.c > > head/lib/libpmc/pmclog.h > > head/sys/dev/hwpmc/hwpmc_logging.c > > head/sys/dev/hwpmc/hwpmc_mod.c > > head/sys/kern/kern_kthread.c > > head/sys/kern/kern_thr.c > > head/sys/kern/kern_thread.c > > head/sys/sys/pmc.h > > head/sys/sys/pmckern.h > > head/sys/sys/pmclog.h > > head/usr.sbin/Makefile > > head/usr.sbin/pmc/Makefile (contents, props changed) > > head/usr.sbin/pmc/cmd_pmc.h (contents, props changed) > > > > Modified: head/lib/libpmc/pmclog.c > > ============================================================================== > > --- head/lib/libpmc/pmclog.c Tue Jun 5 01:05:58 2018 (r334646) > > +++ head/lib/libpmc/pmclog.c Tue Jun 5 04:26:40 2018 (r334647) > > @@ -404,6 +404,19 @@ pmclog_get_event(void *cookie, char **data, > > ssize_t *l > > case PMCLOG_TYPE_USERDATA: > > PMCLOG_READ32(le,ev->pl_u.pl_u.pl_userdata); > > break; > > + case PMCLOG_TYPE_THR_CREATE: > > + PMCLOG_READ32(le,ev->pl_u.pl_tc.pl_tid); > > + PMCLOG_READ32(le,ev->pl_u.pl_tc.pl_pid); > > + PMCLOG_READ32(le,noop); > > + memcpy(ev->pl_u.pl_tc.pl_tdname, le, MAXCOMLEN+1); > > + break; > > + case PMCLOG_TYPE_THR_EXIT: > > + PMCLOG_READ32(le,ev->pl_u.pl_te.pl_tid); > > + break; > > + case PMCLOG_TYPE_PROC_CREATE: > > + PMCLOG_READ32(le,ev->pl_u.pl_pc.pl_pid); > > + memcpy(ev->pl_u.pl_pc.pl_pcomm, le, MAXCOMLEN+1); > > + break; > > default: /* unknown record type */ > > ps->ps_state = PL_STATE_ERROR; > > ev->pl_state = PMCLOG_ERROR; > > > > pmcstat does not know about these new event types, so a `pmcstat -S > cpu_clk_unhalted.core -l 10 -G data.test` produces error messages about > unknown events: See also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230984 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230985