From owner-svn-src-head@FreeBSD.ORG Thu Jan 6 09:32:36 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 237C4106564A; Thu, 6 Jan 2011 09:32:36 +0000 (UTC) (envelope-from etnapierala@googlemail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 5A6EF8FC0C; Thu, 6 Jan 2011 09:32:35 +0000 (UTC) Received: by wyf19 with SMTP id 19so16358870wyf.13 for ; Thu, 06 Jan 2011 01:32:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:sender:subject:mime-version :content-type:from:in-reply-to:date:cc:content-transfer-encoding :message-id:references:to:x-mailer; bh=Ci7bRZkWXLNYabVuRJBCtaI5JhttGe8GZdRcO2GHM4c=; b=W91tWitMXolrMwi6AqX7PTH75yFITraxB5DqWacn5nF5VwCkSr23tgv9sAvJqN3gKl e3gz4JzGhRz1uYwsEaXf2m0LXH6Bdd4+/wuSYB3ITQtf9P2bNJG35gSxgBehcSZyNZNT 95BKxiMrO9kr1q21WLINHULphqC7XGAMMCd5s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; b=rlI2lwOhVs11ePwBnstxhFZL3W/4f5JQ0hUq7vvt8aFNHst7P+rFR3ALK+e1ntY5+y tQQsFRaJPzCnTSiawwN7nwzj+luzUF7JgIQ3HWLSQerE8LZFO/MBG9acHV7wlKSiTQ/Z besF4DxR9tPuf4Si98fGTod1OnOsm0r+g33Rg= Received: by 10.216.187.10 with SMTP id x10mr23001047wem.97.1294305004394; Thu, 06 Jan 2011 01:10:04 -0800 (PST) Received: from [192.168.2.4] (gate19.robnet.pl [194.105.132.219]) by mx.google.com with ESMTPS id t11sm11072035wes.41.2011.01.06.01.10.01 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 06 Jan 2011 01:10:03 -0800 (PST) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Mime-Version: 1.0 (Apple Message framework v1082) Content-Type: text/plain; charset=iso-8859-2 From: =?iso-8859-2?Q?Edward_Tomasz_Napiera=B3a?= In-Reply-To: <4D258533.3@freebsd.org> Date: Thu, 6 Jan 2011 10:09:59 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <8C6A03B3-8A1E-4316-8A7C-1EF4CE10E12B@freebsd.org> References: <201101060833.p068Xmrj008299@svn.freebsd.org> <4D258533.3@freebsd.org> To: Julian Elischer X-Mailer: Apple Mail (2.1082) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r217048 - head/share/man/man9 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jan 2011 09:32:36 -0000 Wiadomo=B6=E6 napisana przez Julian Elischer w dniu 2011-01-06, o godz. = 10:02: > On 1/6/11 12:33 AM, Edward Tomasz Napierala wrote: >> Author: trasz >> Date: Thu Jan 6 08:33:48 2011 >> New Revision: 217048 >> URL: http://svn.freebsd.org/changeset/base/217048 >>=20 >> Log: >> Get rid of bad advice regarding /* NOTREACHED */. Compilers don't >> really need it (one can use __dead2 instead), and style(9) was not >> even consistent with itself in this regard. >>=20 >> Modified: >> head/share/man/man9/style.9 >>=20 >> Modified: head/share/man/man9/style.9 >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/share/man/man9/style.9 Thu Jan 6 08:13:30 2011 = (r217047) >> +++ head/share/man/man9/style.9 Thu Jan 6 08:33:48 2011 = (r217048) >> @@ -470,9 +470,6 @@ statement that cascade should have a >> .Li FALLTHROUGH >> comment. >> Numerical arguments should be checked for accuracy. >> -Code that cannot be reached should have a >> -.Li NOTREACHED >> -comment. >=20 > I object STRONGLY to this change. >=20 > The NOTREACHED is also to help the reader understand what has happened = and as an afterthought > was also useful in LINT. I know know of no technological change to = the average reader that makes > it less useful. What about adding something like this? Code that cannot be reached for non-obvious reasons may have .Li NOTREACHED comment. -- If you cut off my head, what would I say? Me and my head, or me and my = body?