From owner-freebsd-xen@freebsd.org Thu May 12 14:14:29 2016 Return-Path: Delivered-To: freebsd-xen@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D0A41B36CA1 for ; Thu, 12 May 2016 14:14:29 +0000 (UTC) (envelope-from StephenJo@LivingComputerMuseum.org) Received: from mail.vulcan.com (wstcas2.vulcan.com [216.220.192.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.vulcan.com", Issuer "Entrust Certification Authority - L1K" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AE8DA19A5 for ; Thu, 12 May 2016 14:14:28 +0000 (UTC) (envelope-from StephenJo@LivingComputerMuseum.org) Received: from WSTMAIL1.corp.vnw.com (10.0.41.230) by WSTCAS2.corp.vnw.com (10.0.41.64) with Microsoft SMTP Server (TLS) id 14.3.266.1; Thu, 12 May 2016 07:13:05 -0700 Received: from WSTMAIL1.corp.vnw.com (10.0.41.230) by WSTMail1.corp.vnw.com (10.0.41.230) with Microsoft SMTP Server (TLS) id 15.0.1130.7; Thu, 12 May 2016 07:13:04 -0700 Received: from 505CAS2.corp.vnw.com (10.0.100.210) by WSTMAIL1.corp.vnw.com (10.0.41.230) with Microsoft SMTP Server (TLS) id 15.0.1130.7 via Frontend Transport; Thu, 12 May 2016 07:13:04 -0700 Received: from 505MBX1.corp.vnw.com ([169.254.2.139]) by 505CAS2.corp.vnw.com ([10.0.100.210]) with mapi id 14.03.0266.001; Thu, 12 May 2016 07:13:04 -0700 From: Stephen Jones To: "'freebsd-xen@freebsd.org'" CC: =?iso-8859-1?Q?=27Roger_Pau_Monn=E9=27_=28roger=2Epau=40citrix=2Ecom=29?= , "Miguel C (miguelmclara@gmail.com)" , Wei Liu Subject: Re: xn ethernet issues as DOMU under NetBSD DOM0 FIXED! Thread-Topic: xn ethernet issues as DOMU under NetBSD DOM0 FIXED! Thread-Index: AdGsWCvs64f0hdjxS726AnSBgohAJg== Date: Thu, 12 May 2016 14:13:03 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.0.100.218] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2016 14:14:29 -0000 Roger writes: > I think I have found what's causing the issue, but I don't have a NetBSD > Dom0 in order to test the fix, could some of you please test the followin= g patch and report back: > > > https://people.freebsd.org/~royger/0001-xen-netfront-fix-feature-detectio= n.patch > > It should apply cleanly against FreeBSD HEAD. --- a/sys/dev/xen/netfront/netfront.c +++ b/sys/dev/xen/netfront/netfront.c @@ -2016,7 +2016,7 @@ xn_query_features(struct netfront_info *np) device_printf(np->xbdev, "backend features:"); =20 if (xs_scanf(XST_NIL, xenbus_get_otherend_path(np->xbdev), - "feature-sg", NULL, "%d", &val) < 0) + "feature-sg", NULL, "%d", &val) !=3D 0) val =3D 0; =20 np->maxfrags =3D 1; @@ -2026,7 +2026,7 @@ xn_query_features(struct netfront_info *np) } =20 if (xs_scanf(XST_NIL, xenbus_get_otherend_path(np->xbdev), - "feature-gso-tcpv4", NULL, "%d", &val) < 0) + "feature-gso-tcpv4", NULL, "%d", &val) !=3D 0) val =3D 0; =20 np->xn_ifp->if_capabilities &=3D ~(IFCAP_TSO4|IFCAP_LRO); FreeBSD freebsd 11.0-CURRENT FreeBSD 11.0-CURRENT #1: Thu May 12 13:48:47 U= TC 2016 root@freebsd:/usr/src/sys/amd64/compile/SDF amd64 xn0: flags=3D8843 metric 0 mtu 1500 options=3D3 ether 00:16:3e:00:00:30 inet 192.94.73.150 netmask 0xffffff00 broadcast 192.94.73.255=20 nd6 options=3D29 media: Ethernet manual status: active xn0: at device/vif/0 on xenbusb_front0 xn0: Ethernet address: 00:16:3e:00:00:30 xn0: backend features: xn0: link state changed to DOWN xn0: link state changed to UP Indeed this does fix the issue. I am now able to ssh into a FreeBSD 11 DOM= U running on a NetBSD DOM0. I've done some basic in/out transfers over sftp and rates look good, no err= ors. Thank you for putting in an effort to get this working. I hope that your d= iff will be incorporated quickly into=20 FreeBSD 11 and backported where that can be done. =20