From nobody Mon Jan 6 16:30:57 2025 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YRfnJ4Jljz5jpZH; Mon, 06 Jan 2025 16:31:00 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YRfnJ3klMz42ks; Mon, 6 Jan 2025 16:31:00 +0000 (UTC) (envelope-from bapt@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736181060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Xqj+ru+095Glytut7WfRYDGCe0NY29xHCGQUPUgOs7U=; b=p/aoqkx/QJHqTR6x5ywez70xd4voEJksRp19S/E5J5224fOOo3jpsqCGLL0Z2jJaf7ZZ/A UXyjW/fYTqrAdO64oLoJNLcdp3367017Qq4BSDV1dl75axyXhWnplVCLqPMWHrg/MGWbZG S3HJ6Ky/8yELmoHDYL77W6quFNngAMyJEOVhME+Ws3kGqJgj8nj1PMoy5IcCFlqejeNRsd mz80oYEgveYzRhvmTJPXAYgjBZaTs50KeKleKrzOY0gS7PZIefbZeLYm8+yZn+SDkOtU54 qO++UpzVioRi/7WCoZdZuXroCuWq8uSdTM/HNcBJQCd5hWjU9G40Tr6+Lwn2HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1736181060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Xqj+ru+095Glytut7WfRYDGCe0NY29xHCGQUPUgOs7U=; b=dpXlfH5Cp7gjIP7rJTojtub3mDbelKWjHbxBjLPPedl8fhK3yfbaOlXuyp4uslWy9vMySg kATWoL5vVsZaW7KJPdzoUYyObuvswZJ+FIbl8rVlSCFZDx6qofdGMCpNz/2CRSTlZJyVAi ZHEdxQaVsFJpzMLMQyN3c8sBvWX4la8cVKaAKKt+2V+m7FTq3U9x/H+ZJM2AJttPod0wbW Y5p8VK2klxHSaCrrDzPjzOrXYIJ8csUncMr2vlsDd+mQlfXB2OeJk9/J6dPHyC+brCqlJU +y4WXMAWckh46a9ns9kuEQX7GCYl+RVCrM8h8kjs3F3qMOJaOu0hKYoCJ6ybvQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1736181060; a=rsa-sha256; cv=none; b=ALjlu9aLu47Jj5/jRWvY2UlwFBmwvsxQOjn4EaXo4DLjZJycZDmIPIBe59iLzQAFqNKLva ImezKVQPm81hAbR+Kgus2gSUJMygVt6bAKcmY+1ifa3oV0CXl5Tc9dt/2vtvwX4eEncvHm pSPBAt+AiyfugZLRbFwSY7vflYkeInt3SYm3Lxdv5HMGY75KSXeqWN7rfTN3MybjBsSiut CQSllszevBuG24MEUzSq1JpiEfJ1+GvKlABU/Etl+uTHuLUzdjRbprLgdn2lz9Wm1ieis7 4waV+tcCfufYpQdnTJsyzZFRXl7m/aGWyoB8/9iFwrgNOtf99sBD1c8xh4uEAA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from aniel.nours.eu (nours.eu [IPv6:2001:41d0:8:3a4d::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 4YRfnJ0zsPzk40; Mon, 06 Jan 2025 16:31:00 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id 35BE01C5E27; Mon, 06 Jan 2025 17:30:57 +0100 (CET) Date: Mon, 6 Jan 2025 17:30:57 +0100 From: Baptiste Daroussin To: Alexander Leidinger Cc: Xavier Beaudouin , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 2cf6bc1add64 - main - java/openjdk*: Update pkg-message information about fdescfs and procfs Message-ID: References: <202501061418.506EIOj7078214@gitrepo.freebsd.org> <1943c291180.2805.fa4b1493b064008fe79f0f905b8e5741@Leidinger.net> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1943c291180.2805.fa4b1493b064008fe79f0f905b8e5741@Leidinger.net> A quick grep in the source code seems to show /proc is only used for a message that print how to debug: jio_snprintf(buf, sizeof(buf), "gdb /proc/%d/exe %d" The only usecase I can see for /dev/fd is for Java_com_sun_management_internal_OperatingSystemImpl_getOpenFileDescriptorCount0 Which should not be hard to patch using sysctl(kern.proc.nfds) Best regards, Bapt On Mon 06 Jan 16:09, Alexander Leidinger wrote: > Hi, > > It would be good to have some indicators how to determine if it is needed or > not. Some things to watch out for to be able to decide if it is worth a try > or not. > > Bye, > Alexander. > > -- > Send from a mobile device, please forgive brevity and misspellings. > Am 6. Januar 2025 15:20:23 schrieb Xavier Beaudouin : > > > The branch main has been updated by kiwi: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=2cf6bc1add649b35668b449ab35fb04ed0a6d263 > > > > commit 2cf6bc1add649b35668b449ab35fb04ed0a6d263 > > Author: Xavier Beaudouin > > AuthorDate: 2024-12-16 14:30:55 +0000 > > Commit: Xavier Beaudouin > > CommitDate: 2025-01-06 14:16:58 +0000 > > > > java/openjdk*: Update pkg-message information about fdescfs and procfs > > > > OpenJDK installation inform that fdescfs(5) and procfs(5) should be > > mounted when using OpenJDK. > > After doing some test and some traces, it seems that this should be > > no so usefull, some applications will require it, but most of java > > applications doesn't seems to suffer to work or performance when > > such pseudo FS is not mounted. > > > > So this change request permit to let local administrator to decide if > > it is really needed or not. > > > > Sponsored by: Entersekt (previously Modirum MDpay) > > Sponsored by: Klara Inc. > > Approved by: 0mp (mentor) > > PR: 283364 (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283364) > > --- > > java/openjdk11/pkg-message | 4 ++-- > > java/openjdk17/pkg-message | 4 ++-- > > java/openjdk18/pkg-message | 4 ++-- > > java/openjdk19/pkg-message | 4 ++-- > > java/openjdk20/pkg-message | 4 ++-- > > java/openjdk21/pkg-message | 4 ++-- > > java/openjdk22/pkg-message | 4 ++-- > > java/openjdk8/pkg-message | 4 ++-- > > 8 files changed, 16 insertions(+), 16 deletions(-) > > > > diff --git a/java/openjdk11/pkg-message b/java/openjdk11/pkg-message > > index 2ea3d87d89c8..fcb6defe8dcd 100644 > > --- a/java/openjdk11/pkg-message > > +++ b/java/openjdk11/pkg-message > > @@ -1,8 +1,8 @@ > > [ > > { type: install > > message: < > -This OpenJDK implementation requires fdescfs(5) mounted on /dev/fd and > > -procfs(5) mounted on /proc. > > +This OpenJDK implementation may require fdescfs(5) mounted on /dev/fd > > +and procfs(5) mounted on /proc for some applications. > > > > If you have not done it yet, please do the following: > > > > diff --git a/java/openjdk17/pkg-message b/java/openjdk17/pkg-message > > index 2ea3d87d89c8..fcb6defe8dcd 100644 > > --- a/java/openjdk17/pkg-message > > +++ b/java/openjdk17/pkg-message > > @@ -1,8 +1,8 @@ > > [ > > { type: install > > message: < > -This OpenJDK implementation requires fdescfs(5) mounted on /dev/fd and > > -procfs(5) mounted on /proc. > > +This OpenJDK implementation may require fdescfs(5) mounted on /dev/fd > > +and procfs(5) mounted on /proc for some applications. > > > > If you have not done it yet, please do the following: > > > > diff --git a/java/openjdk18/pkg-message b/java/openjdk18/pkg-message > > index 2ea3d87d89c8..fcb6defe8dcd 100644 > > --- a/java/openjdk18/pkg-message > > +++ b/java/openjdk18/pkg-message > > @@ -1,8 +1,8 @@ > > [ > > { type: install > > message: < > -This OpenJDK implementation requires fdescfs(5) mounted on /dev/fd and > > -procfs(5) mounted on /proc. > > +This OpenJDK implementation may require fdescfs(5) mounted on /dev/fd > > +and procfs(5) mounted on /proc for some applications. > > > > If you have not done it yet, please do the following: > > > > diff --git a/java/openjdk19/pkg-message b/java/openjdk19/pkg-message > > index 2ea3d87d89c8..fcb6defe8dcd 100644 > > --- a/java/openjdk19/pkg-message > > +++ b/java/openjdk19/pkg-message > > @@ -1,8 +1,8 @@ > > [ > > { type: install > > message: < > -This OpenJDK implementation requires fdescfs(5) mounted on /dev/fd and > > -procfs(5) mounted on /proc. > > +This OpenJDK implementation may require fdescfs(5) mounted on /dev/fd > > +and procfs(5) mounted on /proc for some applications. > > > > If you have not done it yet, please do the following: > > > > diff --git a/java/openjdk20/pkg-message b/java/openjdk20/pkg-message > > index 2ea3d87d89c8..fcb6defe8dcd 100644 > > --- a/java/openjdk20/pkg-message > > +++ b/java/openjdk20/pkg-message > > @@ -1,8 +1,8 @@ > > [ > > { type: install > > message: < > -This OpenJDK implementation requires fdescfs(5) mounted on /dev/fd and > > -procfs(5) mounted on /proc. > > +This OpenJDK implementation may require fdescfs(5) mounted on /dev/fd > > +and procfs(5) mounted on /proc for some applications. > > > > If you have not done it yet, please do the following: > > > > diff --git a/java/openjdk21/pkg-message b/java/openjdk21/pkg-message > > index 2ea3d87d89c8..fcb6defe8dcd 100644 > > --- a/java/openjdk21/pkg-message > > +++ b/java/openjdk21/pkg-message > > @@ -1,8 +1,8 @@ > > [ > > { type: install > > message: < > -This OpenJDK implementation requires fdescfs(5) mounted on /dev/fd and > > -procfs(5) mounted on /proc. > > +This OpenJDK implementation may require fdescfs(5) mounted on /dev/fd > > +and procfs(5) mounted on /proc for some applications. > > > > If you have not done it yet, please do the following: > > > > diff --git a/java/openjdk22/pkg-message b/java/openjdk22/pkg-message > > index 2ea3d87d89c8..fcb6defe8dcd 100644 > > --- a/java/openjdk22/pkg-message > > +++ b/java/openjdk22/pkg-message > > @@ -1,8 +1,8 @@ > > [ > > { type: install > > message: < > -This OpenJDK implementation requires fdescfs(5) mounted on /dev/fd and > > -procfs(5) mounted on /proc. > > +This OpenJDK implementation may require fdescfs(5) mounted on /dev/fd > > +and procfs(5) mounted on /proc for some applications. > > > > If you have not done it yet, please do the following: > > > > diff --git a/java/openjdk8/pkg-message b/java/openjdk8/pkg-message > > index 2ea3d87d89c8..fcb6defe8dcd 100644 > > --- a/java/openjdk8/pkg-message > > +++ b/java/openjdk8/pkg-message > > @@ -1,8 +1,8 @@ > > [ > > { type: install > > message: < > -This OpenJDK implementation requires fdescfs(5) mounted on /dev/fd and > > -procfs(5) mounted on /proc. > > +This OpenJDK implementation may require fdescfs(5) mounted on /dev/fd > > +and procfs(5) mounted on /proc for some applications. > > > > If you have not done it yet, please do the following: >