From owner-freebsd-current@FreeBSD.ORG Thu Dec 1 01:59:35 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 23F4A106564A; Thu, 1 Dec 2011 01:59:35 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-gx0-f182.google.com (mail-gx0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id 8B9CA8FC12; Thu, 1 Dec 2011 01:59:34 +0000 (UTC) Received: by ggnk5 with SMTP id k5so2055553ggn.13 for ; Wed, 30 Nov 2011 17:59:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=KLEcYTMtxM/BKFeGmaXLYB59WT1XWn5fyt/saa2XVoc=; b=qK2TKxikgcpJxxFyohN7WK/oXQs16W2fad/fBXNXn/FDjfDAiSgS5WbdjFip6+A8zC YPqhVM6RVjkObkwVCEs4dhO3nxzSMZCQvcJqQnD6ZS6aIrFs9rguYoxFGMmJmN+Ol4jT BT0H3HliDf7bLSLPndbzMPGrr/BFdIs0CwM+Y= MIME-Version: 1.0 Received: by 10.182.154.66 with SMTP id vm2mr1036095obb.52.1322704773881; Wed, 30 Nov 2011 17:59:33 -0800 (PST) Received: by 10.182.62.227 with HTTP; Wed, 30 Nov 2011 17:59:33 -0800 (PST) In-Reply-To: <20111201014349.GA61475@freebsd.org> References: <201111291607.26546.jhb@freebsd.org> <20111201002515.GA50028@freebsd.org> <20111201014349.GA61475@freebsd.org> Date: Wed, 30 Nov 2011 17:59:33 -0800 Message-ID: From: Garrett Cooper To: Alexander Best Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Doug Barton , Warner Losh , current@freebsd.org, Warner Losh Subject: Re: Remove debug echo X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2011 01:59:35 -0000 On Wed, Nov 30, 2011 at 5:43 PM, Alexander Best wrote= : > On Wed Nov 30 11, Garrett Cooper wrote: >> On Wed, Nov 30, 2011 at 4:25 PM, Alexander Best wr= ote: >> > On Tue Nov 29 11, Warner Losh wrote: >> >> kill it. >> >> >> >> Warner >> >> On Nov 29, 2011, at 2:07 PM, John Baldwin wrote: >> >> >> >> > Any objections to this? =A0It removes a weird line during 'make -s = buildworld' >> >> > output and I think it was debugging accidentally left in in 213077 = by Warner: >> >> > >> >> > Index: newvers.sh >> >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> >> > --- newvers.sh =A0 =A0 =A0(revision 228074) >> >> > +++ newvers.sh =A0 =A0 =A0(working copy) >> >> > @@ -99,7 +99,6 @@ for dir in /bin /usr/bin /usr/local/bin; do >> >> > done >> >> > >> >> > if [ -n "$svnversion" ] ; then >> >> > - =A0 echo "$svnversion" >> >> > =A0 =A0 svn=3D`cd ${SYSDIR} && $svnversion` >> >> > =A0 =A0 case "$svn" in >> >> > =A0 =A0 [0-9]*) svn=3D" r${svn}" ;; >> > >> > also... >> > >> > when running buildkernel via 'make -s', do we really need all those mo= dule >> > printfs? i see messages for "cleandir", "obj", "depend" and "all". i t= hink for >> > 'make -s', that's pure overkill! >> > >> > for a GENERIC kernel, 'make' enters ~ 670 module dirs. take that times= 4 and >> > you'll get 2680 lines of output. not really *silent*, is it? ;) >> >> =A0 =A0 pmake sucks as far as diagnostic output is concerned when compar= ed >> with gmake. I'd rather not have to fish through with -j1 (if I'm lucky >> and it's not a race) to determine what directory created the "Error >> Code" output. With the printouts discussed here, at least you have a >> chance at determining what the issue was. >> =A0 =A0 Maybe it's just me, but I like noisy builds -- otherwise the >> amount of time I have to spend root-causing the issue becomes >> expensive. > > ehmmm...a noisy silent flag? i totally agree, if we're talking about 'mak= e' in > its default mode, but what's the point of a silent flag, if it produces >= 2500 > lines of output? nobody uses the -s flag for diagnostics. its purpose is = to > build a kernel without producing a lot of output and also not fiddling wi= th > stdout/stderr to achieve that goal. What I really want is this: $ cat Makefile all: foo bar baz yadda foo bar yadda: baz: false $ gmake false gmake: *** [baz] Error 1 ^^^^ $ make all false *** Error code 1 Stop in /tmp. Otherwise diagnosing issues becomes a PITA with -j > 1 (with pmake I have to start using some serious grep'ing, and if I'm lucky I can find the source of error). If I get a few spare cycles I might just implement it and post a patch somewhere (the entering and leaving directory feature of gmake is really nice too, but it's less important.. unless you have the same target in multiple directories).. Thanks, -Garrett