Date: Wed, 8 Aug 2018 10:52:13 -0700 From: Gleb Smirnoff <glebius@freebsd.org> To: Ed Maste <emaste@freebsd.org>, br@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336692 - head/sys/sys Message-ID: <20180808175213.GA420@FreeBSD.org> In-Reply-To: <201807250018.w6P0ILvv074365@repo.freebsd.org> References: <201807250018.w6P0ILvv074365@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 25, 2018 at 12:18:21AM +0000, Ed Maste wrote: E> Author: emaste E> Date: Wed Jul 25 00:18:21 2018 E> New Revision: 336692 E> URL: https://svnweb.freebsd.org/changeset/base/336692 E> E> Log: E> sockopt.h: remove stale comment E> E> Some old compatibility bits were removed in r227503 but this comment E> was left behind. E> E> Reported by: br, via review D11962 E> Sponsored by: The FreeBSD Foundation E> E> Modified: E> head/sys/sys/sockopt.h E> E> Modified: head/sys/sys/sockopt.h E> ============================================================================== E> --- head/sys/sys/sockopt.h Wed Jul 25 00:06:18 2018 (r336691) E> +++ head/sys/sys/sockopt.h Wed Jul 25 00:18:21 2018 (r336692) E> @@ -62,7 +62,6 @@ int sosetopt(struct socket *so, struct sockopt *sopt); E> int sogetopt(struct socket *so, struct sockopt *sopt); E> int sooptcopyin(struct sockopt *sopt, void *buf, size_t len, size_t minlen); E> int sooptcopyout(struct sockopt *sopt, const void *buf, size_t len); E> -/* XXX; prepare mbuf for (__FreeBSD__ < 3) routines. */ E> int soopt_getm(struct sockopt *sopt, struct mbuf **mp); E> int soopt_mcopyin(struct sockopt *sopt, struct mbuf *m); E> int soopt_mcopyout(struct sockopt *sopt, struct mbuf *m); This comment was a good mark to note that these three functions need to go away. But IPv6 still uses them. -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180808175213.GA420>