From owner-freebsd-current@FreeBSD.ORG Mon Apr 18 15:49:09 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DD2CF106568B for ; Mon, 18 Apr 2011 15:49:09 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 6FA098FC26 for ; Mon, 18 Apr 2011 15:49:08 +0000 (UTC) Received: by wwc33 with SMTP id 33so5732190wwc.31 for ; Mon, 18 Apr 2011 08:49:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=oObQ9TqDtsdh/vWpnschMRERwdYgHsHBhU7a+R3uKhI=; b=pv7DzkWu0sGTGNsFWvyhd8+2I1dW1N3VknP6EmrHF6hxvueq4QYZezViV0m2MlZ0nd RFvv7BwmFSWUdDVBoTRAgjumOcYpkza+gJGni0puDqxh4/WVl1lT7N9cFOnT1F48PyTe 0xDf8keQqt4ONpmGhGkrdnriZ0ed2z4VzZ/f4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=xL8d5XEUHHWO1d013dtMMxak0FW696Z7LCYotJS1kr39yOA+PRgF7zA/4SQmYIF89T sKzHKCyhm1kGtDzq6rFRLIVjMinHn9lUhYixJEtQymiRxfwgB4F1dcrIaDUx+2ziCxu0 lfGWu0AX1B1cHQu3JfPgyL12Ghm+XLpCr5ZLg= MIME-Version: 1.0 Received: by 10.216.134.207 with SMTP id s57mr5069083wei.25.1303139864907; Mon, 18 Apr 2011 08:17:44 -0700 (PDT) Sender: mdf356@gmail.com Received: by 10.216.9.67 with HTTP; Mon, 18 Apr 2011 08:17:44 -0700 (PDT) In-Reply-To: <201104180805.40743.jhb@freebsd.org> References: <20110416155122.GA29309@wolfman.devio.us> <201104180805.40743.jhb@freebsd.org> Date: Mon, 18 Apr 2011 08:17:44 -0700 X-Google-Sender-Auth: -nksYBbvEg6dX9Mj1PlrwWGqgvk Message-ID: From: mdf@FreeBSD.org To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org, Nick Ulen Subject: Re: `hw.acpi.thermal.tz0.temperature' disappeared X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2011 15:49:10 -0000 On Mon, Apr 18, 2011 at 5:05 AM, John Baldwin wrote: > On Saturday, April 16, 2011 11:51:22 am Nick Ulen wrote: >> FreeBSD was successfully upgraded. >> >> uname -v >> FreeBSD 9.0-CURRENT #0: Mon Apr 11 18:14:36 MSD 2011 >> root@test:/usr/obj/usr/src/sys/GENERIC >> >> Everything seems to be working well except >> `hw.acpi.thermal.tz0.temperature' disappeared from the list of available >> sysctl variables. >> >> sysctl hw.acpi.thermal. >> >> hw.acpi.thermal.min_runtime: 0 >> hw.acpi.thermal.polling_rate: 10 >> hw.acpi.thermal.user_override: 0 >> hw.acpi.thermal.tz0.active: -1 >> hw.acpi.thermal.tz0.passive_cooling: 0 >> hw.acpi.thermal.tz0.thermal_flags: 0 >> hw.acpi.thermal.tz0._PSV: -1 >> hw.acpi.thermal.tz0._HOT: -1 >> hw.acpi.thermal.tz0._CRT: 90.0C >> hw.acpi.thermal.tz0._TC1: -1 >> hw.acpi.thermal.tz0._TC2: -1 >> hw.acpi.thermal.tz0._TSP: -1 >> >> output from: >> =A0sysctl -a |grep acpi >> is here: https://privatepaste.com/ca08d4658b > > I suspect it is still there, but sysctl doesn't know how to display it > anymore. =A0This is probably due to the changes with formatting of sysctl > information. =A0mdf@ is probably responsible in that case. > > =A0 =A0SYSCTL_ADD_OPAQUE(&sc->tz_sysctl_ctx, SYSCTL_CHILDREN(sc->tz_sysct= l_tree), > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0OID_AUTO, "temperature", CTLFL= AG_RD, &sc->tz_temperature, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0sizeof(sc->tz_temperature), "I= K", > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"current thermal zone temperat= ure"); Oops, yes. The change in r217586 required the type to be set to CTLTYPE_INT to print as format IK. My grep of the source tree shows that acpi_thermal.c is the only affected source file that was using OPAQUE. I'm testing out the fix now. Thanks, matthew