From owner-cvs-ports@FreeBSD.ORG  Sun Jun  6 11:11:08 2004
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 36EF416A4CE; Sun,  6 Jun 2004 11:11:08 -0700 (PDT)
Received: from fillmore.dyndns.org (port-212-202-50-15.dynamic.qsc.de
	[212.202.50.15])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id DCC9343D58; Sun,  6 Jun 2004 11:11:07 -0700 (PDT)
	(envelope-from eikemeier@fillmore-labs.com)
Received: from [172.16.0.2] (helo=fillmore-labs.com)
	by fillmore.dyndns.org with esmtp (Exim 4.34 (FreeBSD))
	id 1BX26o-000KN0-2u; Sun, 06 Jun 2004 20:11:05 +0200
Message-ID: <40C35E35.6080803@fillmore-labs.com>
Date: Sun, 06 Jun 2004 20:11:01 +0200
From: Oliver Eikemeier <eikemeier@fillmore-labs.com>
Organization: Fillmore Labs GmbH - http://www.fillmore-labs.com/
MIME-Version: 1.0
To: Joe Marcus Clarke <marcus@FreeBSD.org>
References: <200406060106.i5616XNX076254@repoman.freebsd.org>
	<40C2CE39.5030402@fillmore-labs.com>
	<1086541625.34425.1.camel@shumai.marcuscom.com>
	<40C350AB.2070407@fillmore-labs.com>
	<1086542154.34425.4.camel@shumai.marcuscom.com>
In-Reply-To: <1086542154.34425.4.camel@shumai.marcuscom.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
User-Agent: KMail/1.5.9
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/devel/portlint Makefileports/devel/portlint/src
 portlint.pl
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Jun 2004 18:11:08 -0000

Joe Marcus Clarke wrote:

> On Sun, 2004-06-06 at 13:13, Oliver Eikemeier wrote:
> 
>>Joe Marcus Clarke wrote:
>>
>>>This was supposed to solve a problem that I've personally hit a few
>>>times.  It was just another check to make sure PKGNAME agrees with what
>>>is in distinfo.
>>
>>Could you give me an example? It might be interesting to add this to my
>>rework of the distfiles stuff in PR 67361:
>>  <http://people.freebsd.org/~eik/patches/distfiles/>
>>
>>If it is deemed useful to integrate distinfo into the ports Makefile one 
>>way or the other, it might not be worth to make efforts to check for 
>>stuff that might be obsolete in the future.
> 
> For instance, when fixing hyphenated PORTNAMEs, I sometimes forget to
> adjust DISTNAME, and thus the port is broken.  I always remember a
> portlint run, but it would never catch the problem.
> 
> Joe

So you need a consistency check without fetching the actual distfiles?
I guess it makes sense to include this into bsd.port.mk, since the
involved code is non-trivial, but the logic is already in place. Should
I add a target to my patch, and what kind of output do you expect?

-Oliver